Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest flutter/flare using Teddy example NoSuchMethodError: The method '>' was called on null. #37

Open
madd86 opened this issue Jan 31, 2019 · 3 comments
Open

Latest flutter/flare using Teddy example NoSuchMethodError: The method '>' was called on null. #37

madd86 opened this issue Jan 31, 2019 · 3 comments
Assignees
@luigi-rosso
Labels
bug Something isn't working

Comments

@madd86
Copy link

madd86 commented Jan 31, 2019

This is the result on both android and ios

screenshot_1548897686
@luigi-rosso luigi-rosso self-assigned this Jan 31, 2019
@luigi-rosso luigi-rosso added the bug Something isn't working label Jan 31, 2019
ricsmania pushed a commit to megasistemas/Flare-Flutter that referenced this issue Feb 1, 2019
Fix 2d-inc#37
217ecdf
@ricsmania
Copy link
Contributor

I also hit this problem and got to fix it with the PR I sent. I noticed that if _trim is null the property isTrimmed returns true, but I believe it should return false in this scenario.

luigi-rosso added a commit that referenced this issue Feb 1, 2019
@luigi-rosso
Fixing issue #37.
d2f9792
@luigi-rosso
Copy link
Contributor

Thanks for the PR! I did it a tiny bit differently so that we avoid the extra comparison. Thanks to both of you for your contributions! This should be fixed in 1.2.1, please give it a try.

@ricsmania
Copy link
Contributor

@luigi-rosso thanks for the prompt solution! About the solution, it's more efficient than mine, and I tested it here and works fine.

@ricsmania ricsmania mentioned this issue Feb 4, 2019
Closed
@billjone billjone mentioned this issue Mar 25, 2019
Open
@helwy helwy mentioned this issue Apr 20, 2019
Open
@barfomellow barfomellow mentioned this issue Jul 6, 2019
Closed
@liujiakuoyx liujiakuoyx mentioned this issue Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luigi-rosso luigi-rosso

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luigi-rosso @ricsmania @madd86