Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code by adding AssetProvider #213

Closed
wants to merge 2 commits into from

Conversation

yuwen-yan
Copy link
Collaborator

@yuwen-yan yuwen-yan commented Dec 26, 2019

This is the first PR to support #202

If this PR is acceptable, I'll add network_flare.dart under provider/ in next PR

@luigi-rosso
Copy link
Contributor

I'm reviewing this now, it looks great. I just want to double-check how the new loading logic interacts with the cache (.load and .onLoaded). One thing that would be nice if this could be done on master instead of stable. We normally work out of master and then merge to dev and then finally to stable when we publish on pub.dev. We did that to mimic the Flutter repo, although we've heard from many that it's counter-intuitive.

I'm going to merge this into a new branch from master and push it up for us to work on (I'll add you as a collaborator). I'm also getting the examples working on it. Thanks so much for the contribution, excited to finally make this better.

@luigi-rosso
Copy link
Contributor

I'm closing this as #214 landed which includes these changes into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants