Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flare_dart path #91

Closed
wants to merge 1 commit into from
Closed

fix flare_dart path #91

wants to merge 1 commit into from

Conversation

mdanics
Copy link

@mdanics mdanics commented May 14, 2019

the previous path was relative and would result in an error if attempted to load the plugin via git

the previous path was relative and would result in an error if attempted to load the plugin via git
@luigi-rosso
Copy link
Contributor

This is intentional, the master branch changes most often and we tend to reference it with a local clone instead of via GitHub pubspec reference. It's also the tree we branch from to do development work, which usually means we'll be working with both flare_dart and flare_flutter locally so having them on the filesystem makes it much easier.

But I do see how that's confusing for someone trying to use the latest bleeding edge. We have a note on the readme about it, but maybe we need to rename the branch/add a new one for this.

@mdanics
Copy link
Author

mdanics commented May 14, 2019

Ah, missed that - my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants