Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create_contact and update_contact #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add create_contact and update_contact #2

wants to merge 13 commits into from

Commits on Mar 16, 2016

  1. Add save_contact 

    Returns vid
    Lloyd Nye authored and Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    b4c94b2 View commit details
    Browse the repository at this point in the history

  2. Make test response match real response format

    Lloyd Nye authored and Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    9b8308c View commit details
    Browse the repository at this point in the history

  3. Test for ClientError handling

    Lloyd Nye authored and Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    c71f8bf View commit details
    Browse the repository at this point in the history

  4. Remove superfluous arg

    Lloyd Nye authored and Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    5c3274a View commit details
    Browse the repository at this point in the history

  5. Add update_contact

    Lloyd Nye authored and Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    c6854e1 View commit details
    Browse the repository at this point in the history

  6. Make contact tests fail if code under test doesn't make the right API… 

    … calls

MockPortalConnection only makes the assertions about API calls in it's __exit__() method
    Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    0471e8f View commit details
    Browse the repository at this point in the history

  7. PEP8 fixes

    Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    3f632b1 View commit details
    Browse the repository at this point in the history

  8. Remove unused variable

    Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    2c64b4b View commit details
    Browse the repository at this point in the history

  9. Avoid doing 2 with statements with the same connection object

    Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    189e36b View commit details
    Browse the repository at this point in the history

  10. Rename save_contact to create_contact

    Lloyd Nye authored and Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    40bb426 View commit details
    Browse the repository at this point in the history

  11. More save/create contact renames 

    Change save contact to create contact in test and simulator classes.

Rename SaveContactClientError to UnsuccessfulCreateContact to match the Unsuccessful prefix that the existing exception-throwing simulators use.
    Francis Devereux committed Mar 16, 2016
    Copy the full SHA
    05d450a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2016

  1. Add UnsuccessfulUpdateContact simulator

    Francis Devereux committed Mar 17, 2016
    Copy the full SHA
    c8e168b View commit details
    Browse the repository at this point in the history

  2. Add test for UnsuccessfulUpdateContact

    Francis Devereux committed Mar 17, 2016
    Copy the full SHA
    434d91a View commit details
    Browse the repository at this point in the history