New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More fragment options + Fix for reality configs #2889
Conversation
Dude You're Amazing! |
Another level 🔥🔥 |
Thanks 👍 |
Thanks for this update |
❤❤ |
❤️❤️❤️ |
Amazing 🌹 |
best |
Thanks mr.vahid🔥🙏🏻 |
🔥🔥🔥🔥 |
Thanks ❤️❤️ |
Hope they accept it😍 |
useful for Iran. |
Great job⚘️ |
nice work. its really useful |
Please add the code. We need this code in Iran, and many thanks to Mr. Vahid. |
@vfarid Could you also fix Early Data? Check This : #2887 |
Thanks Vahid👍🏻 |
thanks. |
I tested early data in path in both import and export of custom config and its just fine. May be there is some issue in your config, dont know. Yo may provide issue details in related thread. |
Very useful.👌👌 |
When you import 1 json config, it's OK, but the problem is when you import Multi Json |
I've tested both and there is no such issue imo. Anyway it is not related to this pr, if you sure there is an issue, open a new issue and send it with details. |
Has the test passed? |
Yes, ive tested it with several configs. When we fragment tlshello on reality configs, they will stop working in more than 90% of configs because sni is fake in reality. Instead we can fragment starting packets as described in xtls docs. |
Thanks ❤️ |
Thanks❤️ |
thank you :)) |
Xray-core v1.8.4 以后 REALITY 服务端支持 tlshello 形式的分片,请测试一下(但还取决于 |
They said "need to be tested" and i tested with several reality configs, most of them will stop working as soon as fragment is activated for tlshello, but they will work if we fragment packets 1-n instrad of packet 0. I am still testing and waiting to get test result from my twitter followers in order to findout if my conclusion is not 100% correct. So if you have any test result that shows tlshello fragment will correct curropted reality config and make it work, please share with me. |
REALITY 服务端支持 tlshello 形式的分片的本意只是防止“中间人通过对 client hello 分片来识别 REALITY”,所以它应当正常工作 @vfarid 你测试使用的服务端是 sing-box 吗?sing-box 没有同步这项更新 |
May be, i will re-check it. |
Perhaps In either way, I still like to have the global fragment settings around, since for me the need for fragment is mostly a network matter, and not necessary a server specific matter. |
I added 3 more fragment packets option for reality configs.
Furthermore, since the fragment option is global and will apply on all configs, and since tlshello will destroy reality configs, I added a condition to detect invalid fragment packets option per config type and replaced it with proper packets type.