Add setStyleById (light and dark themes) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandFromNSK
force-pushed
the
feature/SDK-279-style-support
branch
from
51a95dd
to
a383d7f
Compare
teanet
reviewed
Dec 17, 2020
| @@ -0,0 +1,6 @@ | |||
| import Foundation | |||
|
|
|||
| public enum MapStyle: String { | |||
There was a problem hiding this comment.
доку пишем на все, такие требования
ktoto
reviewed
Dec 17, 2020
Sources/MapGL/MapView.swift
Outdated
| @@ -288,6 +291,15 @@ public class MapView : UIView { | |||
| self.js.setStyleZoom(zoom, options: options) | |||
| } | |||
|
|
|||
| /// Sets the map style by identifie and apply it to the map. | |||
There was a problem hiding this comment.
Suggested change
| /// Sets the map style by identifie and apply it to the map. | |
| /// Sets the map style by identifier and apply it to the map. |
| @@ -112,7 +113,8 @@ final class HelloVC: UIViewController { | |||
| maxBounds: GeographicalBounds( | |||
| northEast: CLLocationCoordinate2D(latitude: 36, longitude: 57), | |||
| southWest: CLLocationCoordinate2D(latitude: 10, longitude: 22) | |||
| ) | |||
| ), | |||
| mapStyleId: self.mapStyle.rawValue | |||
There was a problem hiding this comment.
Надо бы ещё в docs/{en,ru}/examples.md добавить пример с установкой в раздел Creating Map Widget
brandFromNSK
force-pushed
the
feature/SDK-279-style-support
branch
3 times, most recently
from
eb8dcdb
to
4992688
Compare
brandFromNSK
force-pushed
the
feature/SDK-279-style-support
branch
from
4992688
to
dc7cff6
Compare
teanet
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.