Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I-100 Skip waiting if DaemonSet updateStrategy.type == OnDelete #101

Merged
merged 1 commit into from
Jul 5, 2019
Merged

I-100 Skip waiting if DaemonSet updateStrategy.type == OnDelete #101

merged 1 commit into from
Jul 5, 2019

Conversation

rvadim
Copy link
Collaborator

@rvadim rvadim commented Jul 5, 2019 •
edited
Loading

Fix #100

@rvadim rvadim self-assigned this Jul 5, 2019
@codecov-io
Copy link

codecov-io commented Jul 5, 2019 •
edited
Loading

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files          16       16           
  Lines        1362     1362           
=======================================
  Hits         1120     1120           
  Misses        242      242
Impacted Files Coverage Δ
k8s_handle/k8s/provisioner.py 78.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29de19...88ef5ec. Read the comment docs.

furiousassault
furiousassault approved these changes Jul 5, 2019
View reviewed changes
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.

@dekhtyarev
Copy link
Collaborator

LGTM!

@dekhtyarev dekhtyarev merged commit 89f9b03 into master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekhtyarev dekhtyarev dekhtyarev approved these changes

@furiousassault furiousassault furiousassault approved these changes

@FreakyGranny FreakyGranny Awaiting requested review from FreakyGranny

@shreyderina shreyderina Awaiting requested review from shreyderina

Assignees

@rvadim rvadim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s-handle infinitly waiting for DaemonSet update with updateStrategy.type = OnDelete
4 participants
@rvadim @codecov-io @dekhtyarev @furiousassault