Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify regex for templates searching with special keyword #113

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

rvadim
Copy link
Collaborator

@rvadim rvadim commented Jan 27, 2020

Very useful when you apply a lot of cluster configuration like RBAC, PSP, etc

@rvadim rvadim added the enhancement New feature or request label Jan 27, 2020
@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #113 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   82.14%   82.34%   +0.19%     
==========================================
  Files          16       16              
  Lines        1378     1393      +15     
==========================================
+ Hits         1132     1147      +15     
  Misses        246      246
Impacted Files Coverage Δ
k8s_handle/templating.py 92.41% <100%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ab789...17cd0e8. Read the comment docs.

@seleznev
Copy link
Collaborator

May be we should add wildcards support instead? It will cover various another cases not only this one. 🤔

@rvadim rvadim changed the title Add ability to render and apply all available templates Add ability to specify regex for templates searching with special keyword Jan 28, 2020
@rvadim
Copy link
Collaborator Author

rvadim commented Jan 28, 2020

May be we should add wildcards support instead? It will cover various another cases not only this one. thinking

Done. Please check.

k8s_handle/templating.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvadim rvadim merged commit 97e3a42 into master Jan 30, 2020
@rvadim rvadim deleted the templates-all branch January 30, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants