Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking available resources #114

Merged
merged 5 commits into from
Jan 31, 2020

Conversation

justcrafter
Copy link

Problem description
The "deprecated checker" now checks versions and resource availability based on a static file. But in kubernetes settings we can set the available API groups via config file. See example.

Proposed solution

  1. check resource availability bases on API responses k8s
  2. returns error if resource is not found in API
  3. deprication checker should show warnings in logs only

@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #114 into master will increase coverage by 0.73%.
The diff coverage is 87.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   82.14%   82.88%   +0.73%     
==========================================
  Files          16       21       +5     
  Lines        1378     1525     +147     
==========================================
+ Hits         1132     1264     +132     
- Misses        246      261      +15
Impacted Files Coverage Δ
.../k8s/availability_checker/test_resource_getters.py 100% <100%> (ø)
.../availability_checker/test_availability_checker.py 100% <100%> (ø)
k8s_handle/k8s/availability_checker/checker.py 100% <100%> (ø)
k8s_handle/k8s/availability_checker/__init__.py 100% <100%> (ø)
k8s_handle/exceptions.py 100% <100%> (ø) ⬆️
k8s_handle/k8s/api_extensions.py 38.46% <20%> (-11.54%) ⬇️
k8s_handle/__init__.py 44.75% <25%> (-0.9%) ⬇️
...andle/k8s/availability_checker/resource_getters.py 93.02% <93.02%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ab789...c23aa98. Read the comment docs.

k8s_handle/__init__.py Outdated Show resolved Hide resolved
k8s_handle/k8s/api_extensions.py Outdated Show resolved Hide resolved
k8s_handle/k8s/availability_checker/checker.py Outdated Show resolved Hide resolved
k8s_handle/k8s/availability_checker/checker.py Outdated Show resolved Hide resolved
k8s_handle/k8s/availability_checker/resource_getters.py Outdated Show resolved Hide resolved
furiousassault
furiousassault previously approved these changes Jan 29, 2020
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seleznev
seleznev previously approved these changes Jan 29, 2020
k8s_handle/__init__.py Outdated Show resolved Hide resolved
k8s_handle/k8s/api_extensions.py Show resolved Hide resolved
k8s_handle/__init__.py Show resolved Hide resolved
@rvadim
Copy link
Collaborator

rvadim commented Jan 30, 2020

What do you think about adding some documentation about this feature?

@rvadim rvadim added the enhancement New feature or request label Jan 30, 2020
Copy link
Collaborator

@rvadim rvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justcrafter justcrafter requested review from seleznev and furiousassault and removed request for FreakyGranny and dekhtyarev January 31, 2020 05:35
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.

@justcrafter justcrafter merged commit 678304c into 2gis:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants