Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_yaml variable filter #116

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Add to_yaml variable filter #116

merged 1 commit into from
Feb 3, 2020

Conversation

rvadim
Copy link
Collaborator

@rvadim rvadim commented Feb 3, 2020

Implements #115

@rvadim rvadim added the enhancement New feature or request label Feb 3, 2020
@codecov-io
Copy link

codecov-io commented Feb 3, 2020 •
edited
Loading

Codecov Report

Merging #116 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   82.88%   83.11%   +0.22%     
==========================================
  Files          21       21              
  Lines        1525     1528       +3     
==========================================
+ Hits         1264     1270       +6     
+ Misses        261      258       -3
Impacted Files Coverage Δ
k8s_handle/templating.py 94.59% <100%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 678304c...8af0a89. Read the comment docs.

furiousassault
furiousassault reviewed Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM.

README.md Outdated Show resolved Hide resolved
tests/templates_tests/filters.yaml.j2 Outdated Show resolved Hide resolved
furiousassault
furiousassault approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dekhtyarev dekhtyarev merged commit cebfb5f into master Feb 3, 2020
@rvadim rvadim deleted the i-115-to_yaml branch February 4, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekhtyarev dekhtyarev dekhtyarev approved these changes

@furiousassault furiousassault furiousassault approved these changes

@seleznev seleznev Awaiting requested review from seleznev

@justcrafter justcrafter Awaiting requested review from justcrafter

@FreakyGranny FreakyGranny Awaiting requested review from FreakyGranny

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvadim @codecov-io @dekhtyarev @furiousassault