Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ability to concatenate several environment variables into one line #73

Merged
merged 12 commits into from
Jan 18, 2019
Merged

added ability to concatenate several environment variables into one line #73

merged 12 commits into from
Jan 18, 2019

Conversation

otherNoscript
Copy link
Contributor

Fixed #72

@codecov-io
Copy link

codecov-io commented Jan 11, 2019 •
edited
Loading

Codecov Report

Merging #73 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   84.88%   84.85%   -0.03%     
==========================================
  Files          12       12              
  Lines        1184     1182       -2     
==========================================
- Hits         1005     1003       -2     
  Misses        179      179
Impacted Files Coverage Δ
k8s_handle/config.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec5c73...d3fc111. Read the comment docs.

@otherNoscript
Copy link
Contributor Author

ууупс, не в ту ветку

@rvadim rvadim requested review from dekhtyarev and removed request for dekhtyarev January 14, 2019 00:25
@dekhtyarev
Copy link
Collaborator

@otherNoscript , привет!

Обнови PR с мастера, пжлста. У нас произошли некоторые изменения в рамках #70

@otherNoscript
Copy link
Contributor Author

done

rvadim
rvadim previously approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@rvadim rvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dockerfile Outdated Show resolved Hide resolved
@seleznev seleznev self-requested a review January 17, 2019 09:35
seleznev
seleznev previously approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@seleznev seleznev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@otherNoscript otherNoscript dismissed stale reviews from seleznev and rvadim via 3f0c138 January 17, 2019 10:57
@dekhtyarev
Copy link
Collaborator

@otherNoscript , Привет! Больше изменений не планируешь ?

@furiousassault , посмотри тоже, пжлста

furiousassault
furiousassault reviewed Jan 18, 2019
View reviewed changes
Copy link
Collaborator

@furiousassault furiousassault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В остальном looks ok. Перед мержем не забудьте сквашнуть.

.dockerignore Outdated Show resolved Hide resolved
k8s_handle/config.py Outdated Show resolved Hide resolved
@otherNoscript
Copy link
Contributor Author

@dekhtyarev больше изменений нет

furiousassault
furiousassault approved these changes Jan 18, 2019
View reviewed changes
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to rebase/squash before merge. LGTM.

@dekhtyarev dekhtyarev self-requested a review January 18, 2019 08:20
@dekhtyarev dekhtyarev merged commit 0a83144 into 2gis:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekhtyarev dekhtyarev dekhtyarev approved these changes

@furiousassault furiousassault furiousassault approved these changes

@seleznev seleznev seleznev left review comments

@rvadim rvadim rvadim left review comments

Assignees

@dekhtyarev dekhtyarev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@otherNoscript @codecov-io @dekhtyarev @seleznev @rvadim @furiousassault