Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I-74 fix_pvc_diff_result #75

Merged
merged 3 commits into from
Jan 14, 2019
Merged

I-74 fix_pvc_diff_result #75

merged 3 commits into from
Jan 14, 2019

Conversation

dekhtyarev
Copy link
Collaborator

Если PVC и PV не изменились - мы должны пропустить их обновление, т.к. они "immutable"

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #75 into master will decrease coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   84.92%   84.88%   -0.05%     
==========================================
  Files          12       12              
  Lines        1181     1184       +3     
==========================================
+ Hits         1003     1005       +2     
- Misses        178      179       +1
Impacted Files Coverage Δ
k8s_handle/k8s/resource.py 75.71% <75%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f9d5b...24bef6b. Read the comment docs.

k8s/resource.py Outdated Show resolved Hide resolved
furiousassault
furiousassault previously approved these changes Jan 14, 2019
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не считая возвратов True, lgtm.

Copy link
Collaborator

@rvadim rvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dekhtyarev dekhtyarev merged commit dec5c73 into master Jan 14, 2019
@dekhtyarev
Copy link
Collaborator Author

#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants