Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "try another account" button #8

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Add a "try another account" button #8

merged 4 commits into from
Feb 7, 2022

Conversation

GeorgianaElena
Copy link
Member

This adds a button that redirects to the hub/logout endpoint if clicked, which will redirect back to the login page and allow the use of a different account.
try-other-account

Fixes 2i2c-org/infrastructure#973

@yuvipanda
Copy link
Member

this is super clever!

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this is a great idea 👍

It LGTM here - my one question is whether this is something that might be up-streamable to JupyterHub? I feel like this is a useful pattern for other communities as well. Has it been discussed in the JupyterHub world before?

@GeorgianaElena
Copy link
Member Author

GeorgianaElena commented Feb 4, 2022

I feel like this is a useful pattern for other communities as well. Has it been discussed in the JupyterHub world before?

Me too! Maybe this discussion jupyterhub/oauthenticator#414 is a good starting point?

EDIT: Opened a PR in oauthenticator jupyterhub/oauthenticator#484 that adds this html as an example template and documents how to use it 📄

Merging this now 🚀

@damianavila
Copy link

damianavila commented Feb 15, 2022

Not sure if I should delete staging branch here given that it might be used for testing purposes, @GeorgianaElena thoughts?

@damianavila
Copy link

I suppose we should keep it given the description in the top message at #6.

@GeorgianaElena
Copy link
Member Author

Hmm, I suggest deleting it, actually. I believe we should have it just for testing and only keep the branches that are hub specific, like the one with the RStudio logo removal. What do you think?

Also, with 2i2c-org/infrastructure#987, the branch now has to match <cluster-name>-<hub-name>. I should update the Readme too.

@damianavila damianavila deleted the staging branch February 15, 2022 15:43
@damianavila
Copy link

Hmm, I suggest deleting it, actually. I believe we should have it just for testing and only keep the branches that are hub specific, like the one with the RStudio logo removal. What do you think?

I agree! I have removed the branch already.

Also, with 2i2c-org/infrastructure#987, the branch now has to match -. I should update the Readme too.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should a 403 on login clear oauth state?
4 participants