-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "try another account" button #8
Conversation
Merge the main branch into staging
this is super clever! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this is a great idea 👍
It LGTM here - my one question is whether this is something that might be up-streamable to JupyterHub? I feel like this is a useful pattern for other communities as well. Has it been discussed in the JupyterHub world before?
Me too! Maybe this discussion jupyterhub/oauthenticator#414 is a good starting point? EDIT: Opened a PR in Merging this now 🚀 |
Not sure if I should delete |
I suppose we should keep it given the description in the top message at #6. |
Hmm, I suggest deleting it, actually. I believe we should have it just for testing and only keep the branches that are hub specific, like the one with the RStudio logo removal. What do you think? Also, with 2i2c-org/infrastructure#987, the branch now has to match |
I agree! I have removed the branch already.
👍 |
This adds a button that redirects to the
hub/logout
endpoint if clicked, which will redirect back to the login page and allow the use of a different account.Fixes 2i2c-org/infrastructure#973