Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about nbgitpuller installed in environment #110

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Oct 29, 2021

One part of 2i2c-org/infrastructure#790 - this just adds a note that nbgitpuller needs to be installed

@damianavila
Copy link
Contributor

Wondering if it makes sense for us to somehow "test" the images are compatible with us?

@damianavila
Copy link
Contributor

The same goes with dasks-related packages for daskhub with custom images...

Copy link
Member Author

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look at this and think it is good to self-merge. I agree @damianavila that it'd be good to test the environment somehow, but maybe as a part of another PR

Copy link
Member Author

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look at this and think it is good to self-merge. I agree @damianavila that it'd be good to test the environment somehow, but maybe as a part of another PR

Copy link
Member Author

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look at this and think it is good to self-merge. I agree @damianavila that it'd be good to test the environment somehow, but maybe as a part of another PR

Copy link
Member Author

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look at this and think it is good to self-merge. I agree @damianavila that it'd be good to test the environment somehow, but maybe as a part of another PR

@choldgraf choldgraf merged commit 41fa937 into main Nov 13, 2021
@choldgraf choldgraf deleted the nbgitpuller branch November 13, 2021 00:33
@damianavila
Copy link
Contributor

It seems you took a lot of views, @choldgraf 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants