Skip to content

Commit

Permalink
Merge pull request #3606 from 2i2c-org/revert-3604-creds-helper
Browse files Browse the repository at this point in the history
Revert "Move the " UToronto JupyterHub Private Cloner"  GitHub app's details under the default hubs common"
  • Loading branch information
yuvipanda committed Jan 10, 2024
2 parents d5f0c32 + 6f51356 commit eb91e06
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 14 additions & 0 deletions config/clusters/utoronto/common.values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,20 @@ jupyterhub:
memory:
limit: 2G
guarantee: 1G
extraFiles:
github-app-private-key.pem:
mountPath: /etc/github/github-app-private-key.pem
# stringData field will be set via encrypted values files but added here
# to meet the chart schema validation requirements without the need to
# use secret values during the validation.
stringData: "dummy"
gitconfig:
mountPath: /etc/gitconfig
# app-id comes from https://github.com/organizations/utoronto-2i2c/settings/apps/utoronto-jupyterhub-private-cloner
stringData: |
[credential "https://github.com"]
helper = !git-credential-github-app --app-key-file /etc/github/github-app-private-key.pem --app-id 93515
useHttpPath = true
hub:
db:
pvc:
Expand Down
14 changes: 0 additions & 14 deletions config/clusters/utoronto/default-common.values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,6 @@ jupyterhub:
image:
name: quay.io/2i2c/utoronto-image
tag: "14320bae73a0"
extraFiles:
github-app-private-key.pem:
mountPath: /etc/github/github-app-private-key.pem
# stringData field will be set via encrypted values files but added here
# to meet the chart schema validation requirements without the need to
# use secret values during the validation.
stringData: "dummy"
gitconfig:
mountPath: /etc/gitconfig
# app-id comes from https://github.com/organizations/utoronto-2i2c/settings/apps/utoronto-jupyterhub-private-cloner
stringData: |
[credential "https://github.com"]
helper = !git-credential-github-app --app-key-file /etc/github/github-app-private-key.pem --app-id 93515
useHttpPath = true
hub:
config:
Authenticator:
Expand Down

0 comments on commit eb91e06

Please sign in to comment.