Setup gh-scoped-creds on pangeo hub #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds docs on how to do this! pangeo-data/pangeo-docker-images#305 adds the required package to the pangeo docker image. See 2i2c-org/docs#138 (comment) for more discussion
GeorgianaElena
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
What a great feature! 🚀 Thanks @yuvipanda for creating this!
|
Thanks, @GeorgianaElena! |
|
This looks great! My remaining question is how we should surface this to the user. We should update the service docs as well so people discover this! |
@choldgraf, I think @yuvipanda already did that on this PR: rabernat/2i2c-docs#1 |
|
Added a new upstream issue ⬆️ so we can track the upstream work. |
|
Thanks a lot, @damianavila |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Apr 20, 2022
Ref rabernat/2i2c-docs#1 (comment) Follows the docs in 2i2c-org#1219
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Apr 20, 2022
Ref rabernat/2i2c-docs#1 (comment) Follows the docs in 2i2c-org#1219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds docs on how to do this!
pangeo-data/pangeo-docker-images#305 adds
the required package to the pangeo docker image.
See 2i2c-org/docs#138 (comment)
for more discussion