Create a BinderHub helm chart for deployment onto 2i2c's infrastructure #1289
Conversation
dask-gateway is an optional dependency that can be controlled using a condition https://helm.sh/docs/topics/charts/#tags-and-condition-fields-in-dependencies
| memory: 1Gi | ||
| singleuser: | ||
| {{- if .Values.dask-gateway.enabled }} | ||
| # Almost everyone using dask by default wants JupyterLab |
There was a problem hiding this comment.
Unfortunately we can't template values.yaml files :(
binderdask depends on both binderhub and dask-gateway charts
|
Ok, I've gone a different route. Two helm charts: binderhub and binderdask. Binderdask has the dask-gateway dependency. Yes, this sucks, but I also don't know what else to do given that (i) helm charts aren't composable, and (ii) we don't know what the future of BinderHub looks like yet given the upcoming GESIS work. |
|
I think validating that these charts are up-to-date with basehub/daskhub will be less filled with logic acrobatics as well with this approach. |
|
@sgibson91 my suggestion is to just have one chart, and unconditionally enable dask-gateway for now as that's what we want for the pangeo hub. We can work on making it optional when we need to have a binderhub that doesn't have dask. |
|
@yuvipanda ok, made that change! |
|
@yuvipanda shall we add cryptnono as a dependency while we're at it? |
|
@sgibson91 let's skip that in the initial PR as we work out some kinks in the mybinder.org-deployment? |
|
Just pushed an extra commit to include the repo2docker tag. will merge now. |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster |
This PR adds a
binderhubhelm chart with dask-gateway enabled under ourhelm-chartsfolder