Remove support for SMB based AzureFiles - #2676
Merged
Merged
Conversation
We *used* to not use NFS when running on Azure, with AzureFiles. However, we use NFS there too now, and it works fine. We only have one Azure instance, and it uses NFS. This just removes all the code required for Azure File to work with SMB.
consideRatio
approved these changes
Jun 20, 2023
consideRatio
left a comment
consideRatio
left a comment
Contributor
There was a problem hiding this comment.
Wieeeeeeeee nice!!!
Contributor
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5325474092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to not use NFS when running on Azure, with AzureFiles. However, we use NFS there too now, and it works fine. We only have one Azure instance, and it uses NFS.
This just removes all the code required for Azure File to work with SMB.