Remove feature for restricting profile options based on github org membership #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of restricting profile options based on github *org* membership, rather than *teams* membership. This is a complete no-op for any of our communities, as it turns out nobody is using this feature! Getting rid of this makes sure that new communities will not use this feature, as it relies on internal implementation details of the GitHub authenticator and may be hard to upstream when the time comes. See 2i2c-org#4021 for upstreaming plan.
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
yuvipanda
changed the title
GeorgianaElena
approved these changes
May 7, 2024
There was a problem hiding this comment.
I think there are a couple more places where this file needs changes like:
- the title, as it mentions organization based access (or keep the tile, but add a warning right below it as it is not longer supported)
- point 4 that says
**Edit the non-secret config underconfig/clusters/<cluster_name>/<hub_name>.values.yaml.**has ascopesexample specific to orgnanizations (line 72 to line 90)
There was a problem hiding this comment.
good catch @GeorgianaElena! I cleaned that out and removed a bunch of options there as well, as we have nowhere we use read:user at all - it's read:org everywhere. Let's just standardize to that.
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8989677663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of restricting profile options based on github org membership, rather than teams membership. This is a complete no-op for any of our communities, as it turns out nobody is using this feature! Getting rid of this makes sure that new communities will not use this feature, as it relies on internal implementation details of the GitHub authenticator and may be hard to upstream when the time comes. See #4021 for upstreaming plan.
Ref #3900
#3883 is based on this.