docs: add k8s version skew policy notes #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
commented
May 7, 2024
consideRatio
force-pushed
the
pr/skew-policy
branch
from
be5c705
to
18956d8
Compare
sgibson91
approved these changes
May 7, 2024
| api-server etc.), the cloud providers managed workloads (`calico-node` etc.), | ||
| and the k8s node's software (`kubelet` etc.). Since these upgrades aren't done | ||
| at the exact same time, there are known constraints on how the various versions | ||
| can _skew_ in relation to each other. |
There was a problem hiding this comment.
Is there a link to the definition of "skew" in this context we can provide? I'm not fully aware of the concept.
There was a problem hiding this comment.
I didn't find a clear definition for exaple on wikipedia, I linked out to a blog post describing it though - I haven't seen it outside kubernetes context.
There was a problem hiding this comment.
I'll come back to rephase this to not need a link to a blog post - i have to take care of a bay now though
consideRatio
force-pushed
the
pr/skew-policy
branch
from
d0fa410
to
5d10807
Compare
|
Thank you for a lot of reviewing effort today @sgibson91!!! ❤️ 🎉 |
consideRatio
force-pushed
the
pr/skew-policy
branch
from
73f0672
to
9c7fcaa
Compare
|
I iterated on the text - I think it introduces version skew quite a bit better now! I'll go for a merge, thank you for reviewing @sgibson91! |
Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
consideRatio
force-pushed
the
pr/skew-policy
branch
from
9c7fcaa
to
d49a192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing upgrade docs for eks/gke/aks, all of them may need to reference these constraints on how we perform upgrades. Due to that, I've made a dedicated page for this to enable k8s upgrade docs to be briefer and just link out to explain instead of inlining explanations where relevant.
This was identified as relevant for #3464 - there is content in the AWS upgrade docs that could link out to this section now but I'd like to update that separately from this PR.