Handle host file changes ( not working after vi /etc/hosts ) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem whereby VDKQueue wouldn't pick up change events when I sudo vi /etc/hosts because the file is not just updated, the file would be removed, then relinked. So the 'write' change never fired because the underlying file handle changed. This change explictly unregisters interest in /etc/hosts when stopTrackingFileChanges is called and starts watching for change and delete events when startTrackingFileChanges is called. To suspend listening, instead of using a boolean, I simply remove the 'subscription' in VDKQueue. When i am interested again, we readd the path which reinitializes the file descriptor.
2ndalpha
added a commit
that referenced
this pull request
Nov 3, 2015
Handle host file changes ( not working after vi /etc/hosts )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem whereby VDKQueue wouldn't pick up change events
when I sudo vi /etc/hosts because the file is not just updated,
the file would be removed, then relinked. So the
'write' change never fired because the underlying file handle
changed. This change explictly unregisters interest in /etc/hosts
when stopTrackingFileChanges is called and starts watching for change
and delete events when startTrackingFileChanges is called.
To suspend listening, instead of using a boolean, I simply remove
the 'subscription' in VDKQueue. When i am interested again, we readd
the path which reinitializes the file descriptor.