Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count emoji #309

Merged
merged 5 commits into from
Oct 25, 2020
Merged

Count emoji #309

merged 5 commits into from
Oct 25, 2020

Conversation

pr0ph0z
Copy link
Collaborator

@pr0ph0z pr0ph0z commented Oct 25, 2020

I proposed to add a function to count emoji based by this answer to resolve #298 issue. I will open a different pull request to resolve #297. Thanks.

@pr0ph0z pr0ph0z requested a review from 2pai October 25, 2020 01:47
2pai
2pai approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@2pai 2pai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2pai 2pai added the hacktoberfest-accepted Accepted Hacktoberfest label Oct 25, 2020
@2pai 2pai merged commit 6931ef3 into 2pai-dev:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2pai 2pai 2pai approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emoji Issue Create Integration Test & CI Pipeline
2 participants
@pr0ph0z @2pai