Skip to content

Commit

Permalink
nixos/krb5: cleanup, fix and RFC42-ify
Browse files Browse the repository at this point in the history
This replaces the krb5 module's options with RFC 42-style krb5.settings
option, while greatly simplifying the code and fixing a few bugs,
namely:

- NixOS#243068 krb5: Configuration silently gets ignored when set by
  multiple modules
- not being able to use mkIf etc. inside subattributes of
  krb5.libdefaults, e.g. krb5.libdefaults.default_realm = mkIf ...

See NixOS#144575.
Closes NixOS#243068.

Co-authored-by: h7x4 <h7x4@nani.wtf>
  • Loading branch information
2xsaiko and h7x4 committed Dec 21, 2023
1 parent 808d2bd commit 92a541c
Show file tree
Hide file tree
Showing 12 changed files with 246 additions and 478 deletions.
2 changes: 2 additions & 0 deletions nixos/doc/manual/release-notes/rl-2405.section.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ The pre-existing [services.ankisyncd](#opt-services.ankisyncd.enable) has been m
- `services.zfs.zed.enableMail` now uses the global `sendmail` wrapper defined by an email module
(such as msmtp or Postfix). It no longer requires using a special ZFS build with email support.

- The `krb5` module has been rewritten, moving all options but `krb5.enable` and `krb5.package` into `krb5.settings`.

- Gitea 1.21 upgrade has several breaking changes, including:
- Custom themes and other assets that were previously stored in `custom/public/*` now belong in `custom/public/assets/*`
- New instances of Gitea using MySQL now ignore the `[database].CHARSET` config option and always use the `utf8mb4` charset, existing instances should migrate via the `gitea doctor convert` CLI command.
Expand Down
Loading

0 comments on commit 92a541c

Please sign in to comment.