Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Possible bug in ModuleWeaver.AfterWeaving() #21

Open
asherber opened this issue Dec 24, 2016 · 3 comments
Open

Possible bug in ModuleWeaver.AfterWeaving() #21

asherber opened this issue Dec 24, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@asherber
Copy link

I'm working on #13. In ModuleWeaver.AfterWeaving(), I see:

fixedFileInfo.ProductVersion = assemblyVersion;

but then:

stringTable.Values["ProductVersion"] = assemblyInfoVersion;

Is it intentional that these two are set to different values? If not, I can fix this while I'm in here.

@SimonCropp
Copy link
Collaborator

this project is no longer maintained. raise a new issue if u want to take ownership

@304NotModified
Copy link
Owner

304NotModified commented Aug 30, 2018

Will have to investigate this

@304NotModified
Copy link
Owner

note: this change has been introduced in 1.3.0 (#19)

@304NotModified 304NotModified modified the milestones: 2.1, 2.0 Jan 24, 2019
@304NotModified 304NotModified self-assigned this Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants