Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Stamp.Fody replaces AssemblyFileVersion with AssemblyVersion #13

Open
forbjok opened this issue Sep 4, 2015 · 7 comments · May be fixed by #54
Open

Stamp.Fody replaces AssemblyFileVersion with AssemblyVersion #13

forbjok opened this issue Sep 4, 2015 · 7 comments · May be fixed by #54
Assignees
Milestone

Comments

@forbjok
Copy link

forbjok commented Sep 4, 2015

When using Stamp.Fody (1.2.2 w/ Fody 1.29.3) on a project that has both AssemblyVersion and AssemblyFileVersion specified, AssemblyFileVersion gets overwritten by the AssemblyVersion.

In some cases, this is a problem, as we often have an AssemblyVersion that only uses the major and minor version numbers (in order to preserve binary compatibility when there are no breaking changes), while the AssemblyFileVersion is the actual full version including the patch number.

@SimonCropp
Copy link
Collaborator

So what r u proposing?

@forbjok
Copy link
Author

forbjok commented Sep 5, 2015

I think the best solution for this particular situation would be an option to use AssemblyFileVersion instead of AssemblyVersion.

Alternatively, or additionally, an option to only set the AssemblyInformationalVersion without touching the file version. In that case, if the AssemblyVersion was still used, it would contain the wrong version number, but it would at least have the correct Git information and the file version would still be correct.

@SimonCropp
Copy link
Collaborator

ok send me a PR with a configuration switch

@asherber
Copy link

I'm curious, did anything ever happen with this issue? I'm facing the same issue, especially since I'm trying to follow https://codingforsmarties.wordpress.com/2016/01/21/how-to-version-assemblies-destined-for-nuget/

IOW, I want to have something like this:

[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.1.2.0")]
[assembly: AssemblyInformationalVersion("1.1.2+bead1234")]

I'm happy to do some coding on this if it's still open.

@SimonCropp
Copy link
Collaborator

this project is no longer maintained. raise a new issue if u want to take ownership

@SimonCropp
Copy link
Collaborator

closing this as stale. if it is still an problem please raise a new issue

@304NotModified
Copy link
Owner

planned for 1.5

@304NotModified 304NotModified removed this from the 1.5 milestone Jan 24, 2019
@304NotModified 304NotModified linked a pull request Jan 24, 2019 that will close this issue
2 tasks
@304NotModified 304NotModified self-assigned this Jan 24, 2019
@304NotModified 304NotModified added this to the 2.0 milestone Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants