OPAL-544 #103
Merged
OPAL-544 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AB-USAF
reviewed
Jun 27, 2024
AB-USAF
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was happening because we were trying to index an empty df in index_sql/lite - specifically, the 'entry' df in generate_index() was empty because we were calling create_index_from_fs and giving it the path of only a json file with an index basket type so it was returning an empty df.
The hot fix was to just skip track_basket when the df was empty.
I've tried finding a better solution but I am still new to the sql backend and weave - I am open to better ideas!