New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added lock feature #4
Conversation
Do not merge this now. It has a bug. Will fix this tomorrow. |
So far so good! However, is it possible that you could use hive instead of shared_preferences for local storage, as hive's performance is much better and I just recently migrated the app from using shared_preferences to hive. |
Okay will be changing that too. |
Changed Android app package name to `com.notes_app` Changed iOS Face ID reason to a proper reason
@31Carlton7 Don't merge this PR yet. This needs further testing and polishing. |
Hi @31Carlton7 Actually I think it's much consistent to work with |
- Replaced a deprecated API in AndroidManifest.xml - Fixed a bug in `authorisation.dart` that prevented the user from changing lock status
- Moved authenticate() under home_view.dart
@31Carlton7 I tried to fix most of the bugs. Here, the contents of the top most note remains visible prior to authorization. I'm not much well accustomed to state management. Perhaps this bug can be solved by delaying the render of Also you can now MERGE this PR. |
- This is a bug noticed in Android. For more reference: flutter/flutter#83773
I'll take a look at it either tonight or tomorrow! |
I didn't change back to |
I just went through the code and tested it, and the feature doesn't work. None of the notes are locked, and it didn't exactly do anything. Please review your code and update the app to lock the notes and require password auth when trying to view a note. |
VID-20211117-WA0038.mp4I tested this on multiple devices. |
@31Carlton7 awaiting your reply. |
Lets the user to use biometrics as well as pin or pattern.
Also adds the ability to lock or unlock the app from the Profile section.
Uses
shared_preferences
to check if the user has turned on locking.Uses
local_auth
for the actual authorisation feature to work.Addresses #2