Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash game listing and metadata handling #370

Merged
merged 39 commits into from
Oct 2, 2020

Conversation

Daft-Freak
Copy link
Collaborator

@Daft-Freak Daft-Freak commented Sep 27, 2020

Changes for listing games in flash and using the game metadata. Also some cleanup stuff. Has a few unfinished bits:

  • Doesn't unload metadata when a game has none
  • A block is a 64k flash sector, could be anywhere down to 4k with subsector erases
  • The CMake function for metadata only detects changes on the yaml, not the images
  • There's a TODO in there for skipping to the end of a game while scanning flash
  • After you flash a game from the SD, it has two identical entries in the list
  • No RGB splash handling (tool doesn't generate them (yet?))

@Gadgetoid Gadgetoid mentioned this pull request Sep 30, 2020
32 tasks
@Daft-Freak
Copy link
Collaborator Author

Now that the metadata tool is released, what's left to do here? (I'm assuming at least some UI stuff.)

@Daft-Freak Daft-Freak changed the title WIP: Flash game listing and metadata handling Flash game listing and metadata handling Oct 1, 2020
@Gadgetoid
Copy link
Contributor

Gadgetoid commented Oct 2, 2020

Haven't built and run this for a while, will try. Broadly I think we need:

  • Some UI - tabs along the top with the current directory centered (this will be fun if they're not fixed width) or left aligned (easier but you wont see what the prev directory is)
  • Author displayed under description, maybe version too?
  • ... I'm not sure!

image

Edit: Just built and ran, your treatment of folders is beautiful and way cleaner than my overthought tab abomination

@Gadgetoid Gadgetoid merged commit 24a9c70 into 32blit:master Oct 2, 2020
@Gadgetoid
Copy link
Contributor

'tis a glorious day that this most immense of PRs gets merged and makes our menu

S U P E R A W E S O M E

@Daft-Freak Daft-Freak deleted the flash-list-meta branch November 20, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants