-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flash game listing and metadata handling #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a012905
to
930a1ed
Compare
Needed for scanning flash in firmware init
Using a fixed offset baked into the bin until PIC is done...
f0716fa
to
8ec3f0e
Compare
blit_metadata (target-name metadata.yml)
End is needed for metadata, start is temporary.
There's already a lot in there
Use a giant stack buffer, we have loads of it
Currently toggled with dpad left/right
This is a little rough around the edges but should expand the firmware to enable switching between game lists in top level directories. Flash content is currently appended as a fake directory called FLASH... don't make a directory with this name, it might explode!
8ec3f0e
to
1841561
Compare
Now that the metadata tool is released, what's left to do here? (I'm assuming at least some UI stuff.) |
Haven't built and run this for a while, will try. Broadly I think we need:
Edit: Just built and ran, your treatment of folders is beautiful and way cleaner than my overthought tab abomination |
'tis a glorious day that this most immense of PRs gets merged and makes our menu S U P E R A W E S O M E |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for listing games in flash and using the game metadata. Also some cleanup stuff. Has a few unfinished bits:
Doesn't unload metadata when a game has noneThere's a TODO in there for skipping to the end of a game while scanning flashAfter you flash a game from the SD, it has two identical entries in the list