Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewability #10

Merged
merged 7 commits into from
Sep 11, 2018
Merged

Viewability #10

merged 7 commits into from
Sep 11, 2018

Conversation

glebglushtsov
Copy link

Type of change

  • [x ] Feature

Description of change

Calculate and contribute ad slot viewability to TTX Requets.

curlyblueeagle
curlyblueeagle reviewed Sep 11, 2018
View reviewed changes
modules/33acrossBidAdapter.js
}

/**
* Viewability contribution to request..
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting usage of the Contributor Pattern.
Curious to know why 1) you'd want to employ closure to construct the contribution function 2) you'd want to clone ttxRequest and it's descendents. Why not just have a function that returns a new banner.ext object that contains the viewability value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see this is the way contributor pattern is implemented in 33xchange which I was using as a reference.

  1. We may want viewability contributed differently depending on the RevCTRL product (e.g. 'siab' versus 'inview' versus 'infeed').
  2. To secure original request immutability.

curlyblueeagle
curlyblueeagle reviewed Sep 11, 2018
View reviewed changes
modules/33acrossBidAdapter.js

return { width, height, left, top, right, bottom };
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate what _transformSizes does? Assuming that the sizes from the bidRequest object will be something like following:

[[320, 50], [320,100]...]
[[320, 50]]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how do you think we should treat an undefined size? Don't recall how Prebid core treats sizes not being set in the ad unit parameters. If it simply throws errors, should we consider including a check for size in isBidRequestValid ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_transformSizes() proceeds both size formats GPT supports (array and array of array):

  1. [w, h]
  2. [[w, h], [w, h]]

https://support.google.com/admanager/answer/1638622

curlyblueeagle
curlyblueeagle reviewed Sep 11, 2018
View reviewed changes
modules/33acrossBidAdapter.js

/*
* Infer data for the request payload
*/
ttxRequest.imp = [];
ttxRequest.imp[0] = {
banner: {
format: bidRequest.sizes.map(_getFormatSize)
format: sizes.map(size => Object.assign(size, {ext: {}}))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not use _transformSizes method here to construct the format sizes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sizes constant already has transformed sizes. So I just add ext: {} to each of them.

curlyblueeagle
curlyblueeagle reviewed Sep 11, 2018
View reviewed changes
test/spec/modules/33acrossBidAdapter_spec.js
this.build = () => ttxRequest;
}

function ServerRequestBuilder() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

curlyblueeagle
curlyblueeagle reviewed Sep 11, 2018
View reviewed changes
Copy link
Collaborator

@curlyblueeagle curlyblueeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just posed a few questions requesting clarification. But otherwise PR looks good!

@curlyblueeagle
Copy link
Collaborator

Looks good to me, feel free to merge

@glebglushtsov glebglushtsov merged commit 558e45c into master Sep 11, 2018
@glebglushtsov glebglushtsov mentioned this pull request Sep 12, 2018
Merged
glebglushtsov pushed a commit that referenced this pull request Nov 7, 2018
@jsnellbaker
Rivr Analytics Adapter (prebid#3202)
432c656 
* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request #11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* Rvr 2005 rvr analytics adapter (#4)

* Submitting EMX Digital Adapter (prebid#3173)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* TheMediaGrid Bid Adapter (prebid#3204)

* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Adding user sync method for IFRAME and Pixel (prebid#3232)

* Submitting EMX Digital Prebid Adapter

Submitting EMX Digital Prebid Adapter code

* fixing lint errors. updating our md

* updating to const/let variables. adding test spec.

* fixed linting on test spec js

* adding emx usersync methods

* updates (prebid#3162)

* Only set native targeting if value exists. (prebid#3225)

* add nolint command line option, similar to notest (prebid#3234)

* add inskin iab vendor id: enables consent via string (prebid#3235)

* Added user sync support for undertone bid adapter (prebid#3172)

* Added user sync support for undertone bid adapter (new pull request)

* Added user sync support for undertone bid adapter

* fix indentation

* Changed utils.getWindowTop() with the newer prebid utilities

* Updating Auction Init Pick for timestamp + Test update (prebid#3223)

* Updating Auction Init Pick for timestamp + Test update

* Updating Auction Init to include  once again + Rubicon Analytics update accordingly

* Removing  from auction init events in favor of old

* Add code, test, and doc for Adikteev adapter (prebid#3229)

* Add code, test, and doc for Adikteev adapter

* Reflect comments on other PR

http://prebid.org/dev-docs/bidder-adaptor.html#referrers
prebid#3230 (comment)

* 'currency' isn't a bidder-specific param

Update PR following this remark on another one:
prebid#3228 (comment)

* Add integration example, fix bid requestId

* Quantcast adapter onTimeout (prebid#3239)

* onTimeout WIP

* test for onTimeout

* some renaming

* cleanup

* cleanup

* trying to fix the test

* using ajax instead of fetch

* Test cleanup (prebid#3238)

* stub pixel call in justpremium tests

* properly stub geolocation services to prevent prompts

* stub img creation as well to prevent call in justpremium

* Appnexus adapter: Added dealPriority and dealCode to bidResponse (prebid#3201)

* Added dealPriority and dealCode to appnexus adapter

* update failed test

* added namespace and did deep merge

* keep all properties together

* use unit id being sent instead of hard coded auid (prebid#3236)

* use unit id being sent instead of hard coded auid

* make multiple requests

* removes commented out code. adds aus param back

* Prebid 1.30.0 Release

* increment pre version

* fix deal targeting for cpm 0 (prebid#3233)

* YIELDONE adapter - support Video (prebid#3227)

* added UserSync

* added UserSync Unit Test

* support for multi sizes

* register the adapter as supporting video

* supporting video

* change requestId acquisition method

* fix the parameter name of dealID

* update test parameters

* support instream video

* add test for bidRequest

* add test for interpretResponse

* add test params

* add note to documentaion

* clarifying the multi-format support message

* rtbhouseBidAdapter changes (prebid#3241)

* Add transactionId support

* Change site getting method

* Add bidfloor param

* correct user agent value population (prebid#3248)

* RVR-1124 Setup initial skeleton analytics adapter that can send something.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Formatted auction/events data to fit needed schema.

* RVR-1135 fetched device data.

* Applied feedback.

* Applied feedback.

* Fetched core.

* Added click handler for reporting banners click events.

* Applied analyzer for reporting displayed impressions.

* Applied feedback.

* Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

RVR-1214 Invoke handlers on rendering

* RVR-1214 Invoked handlers right after ad is displayed.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1192-configuration-global-parameters (pull request #8)

RVR-1192 Configuration/Global parameters

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

RVR-1181 Prebid.js Unit tests setup

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1247-additional-data-to-impression-records (pull request #9)

RVR-1247 Additional data to impression records

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

RVR-1249 Add requested bids to auction object request.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Merged in RVR-1261-fix-tests (pull request #11)

RVR-1261 fix tests

* RVR-1261 Secured adapter from no containers configuration. And changed fetching URL.

* RVR-1261 Added event check for request and changed some names.

* Applied feedback.

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* RVR-1352 analytics adapter bugs

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

* Fixed bug with geolocation notification.

* fixed missing bracket.

* one more fix.

* RVR-1357 Different optimisation responses & tracking into auction event

* RVR-1852 - Add content type and hardcoded auth headers

(cherry picked from commit 4def881)

* RVR-1852 - Change tracker host

* RVR-1852 - Override content type instead of adding header

* RVR-1914 Consistent data types in events

Also removes undefined and null properties in audience events

* Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17)

RVR-1883 Add Basic Access Authentication

* RVR-1914 - Rename functions

* RVR-1914 - Set default total_duration to null in bid response

* RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token

* RVR-1883 - Restore stub after every test not just at the end

* RVR-1883 - Remove commented code

* Increase code coverage

* Fix for IE 11.0.0 and Safari 8.0.8 - includes()

Use core-js includes function for array

* Restore pbjs_api_spec.js

* Fix API calls for rivr analytics impressions and clicks

* RVR-2005 - Change auction object model

* RVR-2005 - Set rvr_usr_id cookie

* RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers

We have the same infos all collected in AUCTION_END

* RVR-2005 - build Bidders Array From Auction End

* RVR-2005 - build impressions Array From Auction End

* RVR-2005 - set status of winning bid

* RVR-2005 - cleanup

* RVR-2005 - adapt enableAnalytics() test

* RVR-2005 - adapt all tests

* RVR-2005 - Add Rivr Analytics adapter md file

* RVR-2005 - rewrite connectAllUnits

* RVR-2005 - correct typo

* RVR-2005 - use IE compatible find()
glebglushtsov pushed a commit that referenced this pull request May 23, 2019
@jsnellbaker
Rvr 2369 Refactor events handling (prebid#3683)
d3f4d28 
* Rvr 2369 Refactor events handling (#9)

* RVR-2177 - Refactor events handling

* RVR-2087 - Inject pbjsGlobalVariable into rivraddon

* RVR-2087 - update adapterManager dependency

* RVR-2087 - Add ADD_AD_UNITS to Prebid.JS trackable events

* RVR-2369 - Update package-lock.json

* Rvr 2369 prevent duplicate events (#10)

## Type of change
- [x] Refactoring (no functional changes, no api changes)

## Description of change

Refactor rivrAnalyticsAdapter.js events handling.


## History

* RVR-2087 - update adapterManager dependency

* RVR-2369 - Update package-lock.json

* RVR-2369 - Revert changes in main Analytics adapter

It will be handled in a separate PR

* RVR-2369 - Use relative import paths

Needed for prebid#3435
curlyblueeagle pushed a commit that referenced this pull request Jan 28, 2020
@anand-venkatraman @robertrmartinez
PulsePoint adapter - Video support + userId module support (prebid#3937)
e28792e 
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* initial commit

* Adding ortb params

* Outstream fixes

* Minor fixes

* Test fixes

* Minor refactor

* Minor changes

* Removing yarn lock file

* battr fix and added test

* PulsePoint adapter - user id module support (#10)

* Making user sync pixels https as well.

* fixing review comment
curlyblueeagle pushed a commit that referenced this pull request Jun 4, 2020
@abijr @juanbono @raz-adroll
NextRoll Bidder Adapter (prebid#4829)
0ae0bff 
* First implementation of the AdRoll adapter (#1)

* Fix request and bid id (#5)

* Send Zone ID (#6)

* Add age check before fastbid eval (#7)

* Add age check before fastbid eval

* Fix linting

* Add date check (#8)

* Add date exists check

* Remove logging statement

* Fix bidRequest validation (#9)

* Fix deprecated function usage (#10)

* [SENG-2757] remove custom function from adapter (#11)

* remove loadExternalScript function

* add adroll to the adloader whitelist

* Handle nextroll id (#12)

* Handle nextroll id

* Remove double nesting in user obj

* Revert change to publisherTagAvailable

* Rename adroll -> nextroll (#14)

* Rename fastbid -> pubtag functions and variables (#15)

* Improve coverage of tests

* Add docs

* Add docs

* Improve sizes and add sellerid

* Add maintainer email

* Fix CI problem

* Fix IE tests

* Replace second instance of find

* Fix types used in the doc

Match prebid/prebid.github.io#1796

* Remove unused fields in spec

* Add ccpa support

* Remove external script usage

* Remove IP field

* Remove pubtag key

* Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function

Co-authored-by: Juan Bono <juanbono94@gmail.com>
Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
terryc33x pushed a commit that referenced this pull request Aug 7, 2020
@pbrudnick @raz-adroll @abijr
CCPA modifications in the NextRoll adapter (prebid#5409)
2a06f08 
* Add native support

* Add response testing

* DRY test

* Change required from bool to int

* Set mediaType

* Fixes objects

* Fixes object access

* Remove ad property, only set it for banner

* Update tests

* Moving hardcoding values to constants

* Update docs with native information

* Revert "Add native support"

* Getting rid of CCPA adapter validation (#9)

* fix linter errors (#10)

Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
Co-authored-by: Abimael Martinez <abijr@users.noreply.github.com>
curlyblueeagle pushed a commit that referenced this pull request Jan 20, 2021
@GLStephen
Add PubWise Bid Adapter (prebid#6044)
9143962 
* updates for first cut at bidder

* fix up height and width

* adds test spec

* remove hello_world from commit'

* updates to support native and fix issues found in initial review

* fix handling of new node in response for native vs banner

* updates to handle OpenRTB base

* updates to support RTB style calls

* updates to get back to parity

* updates to testing

* updates to test media type handling

* updates to handling testing

* updates to testing

* remove report file

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to handling of gdpr

* Delete hello_world.html

* remove hellow-world-sample

* Pubwise 481 (#7)

* updates to support PubWise bid adapter, test cases and documentation

* updates to fix param tes

* Pubwise 481 (#8)

* fixes for unit testing

* remove unused variables and params

* Updates to Remove Unused Vars (#9)

* remove unused vars

* updates to fix up used and unsused params

* updates to fix up used and unsused params (#10)

* updates to fix up used and unsused params

* updates to remove usersync and add gvlid

* Pubwise 481 (#11)

* updates to remove usersync, add https, and add gvlid

* Update pubwiseBidAdapter.js

* updates to remove json, to remove options hit
carlosfelix pushed a commit that referenced this pull request Mar 15, 2024
@PavloMalashnyak
Blockthrough Bid Adapter: initial release (prebid#10870)
ab7068e 
* PE-87: Implement Prebid Adapter (#1)

* PE-87: implement BT Bid Adapter

* PE-87: rework adapter to use ortbConverter lib, make requested changes

* PE-87: update imports

* PE-110: Add user sync logic to the Prebid Adapter (#3)

* PE-110: add user sync logic

* PE-110: update userSync url

* PE-110: check if iframe is enabled before setting params

* PE-111: BT Prebid Adapter can request AA ads or regular ads (#2)

* PE-120: Send Prebid Bidder info to BT Server (#4)

* PE-120: add btBidderCode to the bid object

* PE-120: use single quotes for logs string

* PE-123: Add More Metadata in site.ext.blockthrough (#5)

* PE-123: send additional meta data

* PE-123: send auctionID under imp.ext.prebid.blockthrough

* PE-123: use ortb2 config to set site.ext params

* PE-123: sent auctionId in ext.prebid.blockthrough.auctionID

* PE-123: update logs for bidderConfig setup

* PE-000: check if blockthrough is defined (#6)

* PE-87: remove BT specific logic (#7)

* Implement Blockthrough Prebid Adapter

* PE-87: Implement Prebid Adapter - misc fixes (#9)

* PE-87: rename test file, add bidder config

* PE-87: increase ttl

* PE-000: fix test

* BP-74: Change the way we enable debug (#10)

* BP-79: Send GPID as a part of `imp[].ext` (#11)

* BP-79: send gpid in imp.ext

* BP-79: add optional operator

* BP-90: Update Cookie Sync Logic (#12)

* BP-90: pass bidder to cookie sync

* BP-90: update sync logic, fix typo

* BP-90: use const for syncs variable

* BP-55: Re-add endpoint URLs (#13)

* BP-91: Add prebid JS version to auction request (#14)
carlosfelix pushed a commit that referenced this pull request Apr 12, 2024
@pashaGhub @eldzis
setupad Bid Adapter: initial commit (prebid#11008)
48113b1 
* create setupadBidAdapter

* add setupadBidAdapter

* update setupadBidAdapter

* update metrics collection

* update analytics collection

* update getUserSyncs

* add setupadAnalyticsAdapter.js

* test setupadAnalyticsAdapter

* remove test: 1

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* clean up && seat bugfix

* clean up logs

* add userID module handling

* update md && clean up

* Send setupad only on bidRequested

* Fix bidResponse and bidWon responses

* Improve bidResponse and bidWon logic

* Revert changes to specific files

* Remove test parameter

* Fix multiple bidResponse and bidTimeout calls to getPixelUrl

* eslint errors fixes(brackets added)

* Add extra checks for events

* Fix BIDDER_CODE const

* update reporting endpoint

* update setupadBidAdapter_spec.js REPORT_ENDPOINT

* update readme

* Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

* Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* # This is a combination of 20 commits.
# This is the 1st commit message:

add setupadBidAdapter

# This is the commit message #2:

update setupadBidAdapter

# This is the commit message #3:

update metrics collection

# This is the commit message #4:

update analytics collection

# This is the commit message #5:

update getUserSyncs

# This is the commit message #6:

add setupadAnalyticsAdapter.js

# This is the commit message #7:

test setupadAnalyticsAdapter

# This is the commit message #8:

remove test: 1

# This is the commit message #9:

add GVLID && bug fixes && test updates

# This is the commit message #10:

remove setupadAnalyticsAdapter

# This is the commit message #11:

add userID module handling

# This is the commit message #12:

clean up && seat bugfix

# This is the commit message #13:

add userID module handling

# This is the commit message #14:

add GVLID && bug fixes && test updates

# This is the commit message #15:

remove setupadAnalyticsAdapter

# This is the commit message #16:

add userID module handling

# This is the commit message #17:

clean up logs

# This is the commit message #18:

update md && clean up

# This is the commit message #19:

Send setupad only on bidRequested

# This is the commit message #20:

Fix bidResponse and bidWon responses

* # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a
parent cecfce3
author pavel <pavel@setupad.com> 1706627437 +0200
committer pavel <pavel@setupad.com> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message #22:

Remove test parameter

* # This is a combination of 26 commits.
parent cecfce3
author pavel <pavel@setupad.com> 1706627437 +0200
committer pavel <pavel@setupad.com> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message #22:

Remove test parameter

# This is the commit message #23:

Fix multiple bidResponse and bidTimeout calls to getPixelUrl

# This is the commit message #25:

eslint errors fixes(brackets added)

# This is the commit message #26:

Add extra checks for events

* parent 75178b9
author pavel <pavel@setupad.com> 1706627694 +0200
committer pavel <pavel@setupad.com> 1706627694 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC
 s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ
 b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI
 DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY
 Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK
 buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp
 lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o
 Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR
 lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS
 OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0
 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH
 AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA=
 =Gbog
 -----END PGP SIGNATURE-----

bugfixes

update setupadBidAdapter_spec.js REPORT_ENDPOINT

update readme

Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* change double quote to single quote

---------

Co-authored-by: pavel <pavel@setupad.com>
Co-authored-by: Elgars Grodnis <elgars@setupad.com>

* bugfix setupadBidAdapter

remove getAdEl, spelling correction

* add onBidWon event

onBidWon event handling moved from custom to native onBidWon method

* minor bugfixes && remove funk getSiteObj && getDeviceObj

---------

Co-authored-by: pavel <pavel@setupad.com>
Co-authored-by: Elgars Grodnis <elgars@setupad.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curlyblueeagle curlyblueeagle curlyblueeagle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@glebglushtsov @curlyblueeagle