-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
after saving, file looks different #81
Comments
Hi Andrey, please provide file attachments If you can. |
hi. I will try to remove critical data and prepare file for you. http://www.ecma-international.org/publications/standards/Ecma-376.htm |
The lib is based on the ECMA-376 5th edition. |
ok, here are files: before updating after updating What steps to reproduce:
Open a new file and you will see that at sheet 3.2 we have broken formatting. I can't provide any data(to much to cleanup), but right now looks like only formatting on this page breaks. 3.1 looks fine. P.S.: file size of after is much lesser (about 300k) |
@xuri Probably it's a good idea to write at Readme about ECMA-376 5th edition |
Thanks for your issue, I have fixed it by adding missing element |
Well, it's much better now, but still looks different. before (3.8Mb file): after(3.3Mb file): have no ideas why :( And file is still lesser by 500kb after saving :( 500Kb somewhere gone. |
If it's important, look for G14 at 3.2 sheet. I'm talking about these cells - lost their formatting after saving: |
The cells that look different (no border style) are generated by the internal function |
@xuri do you mean that somewhere completeCol do something with cell that I didn't touch?! P.S.: about performance - impact is not so high, at least for my case (about 10K rows) |
Yes, the function |
I checked generated file - visually looks same! Huh....thanks man, I started to afraid that I did a bad choice to choose Go without testing saving ability of xls libs. I will get feedback from end-user next week probably, maybe I miss something. Hope everything is fine now :) |
I got another problem. After adding a new Sheet at that file I'm getting "Corrupted file" and sometimes Excel can't repair it. |
Could you provide file attachments and more details? |
I need to "prepare data". But at least one issue is:
Looks like there is something that break file :( Probably original issue was because of that. |
Ok, looks like it has nothing with starter issue, so i'm closing it and will create a new one if required. |
some cells at each row can be merged, BUT Col A, and Col B are simple - only style formatting.
More overs, some rows(quite a lot) that I'm not updating - after saving looks different.
Let's recap - I only update some simple cells at some rows. Why rows that I'm not touching looks different?! :(
The text was updated successfully, but these errors were encountered: