Issue 2375 - CLI - Healthcheck - revise and add new checks

Description:
Updated the healthcheck tests with nsslapd-accesslog-logbuffering
settings so it does not report a warning.
Also adjusted certificate tests so it covers days in leap year.

Relates: #2375

Reviewed by: @vashirov (Thanks!)

dirsrvtests/tests/suites/healthcheck/health_repl_test.py

@@ -107,6 +107,10 @@ def test_healthcheck_replication_replica_not_reachable(topology_m2):
     M1 = topology_m2.ms['supplier1']
     M2 = topology_m2.ms['supplier2']
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    M1.config.set('nsslapd-accesslog-logbuffering', 'on')
+    M2.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     set_changelog_trimming(M1)
 
     log.info('Set nsds5replicaport for the replication agreement to an unreachable port')
@@ -156,6 +160,9 @@ def test_healthcheck_changelog_trimming_not_configured(topology_m2):
 
     M1 = topology_m2.ms['supplier1']
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    M1.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     RET_CODE = 'DSCLLE0001'
 
     log.info('Get the changelog entries for M1')

dirsrvtests/tests/suites/healthcheck/health_security_test.py

@@ -102,6 +102,9 @@ def test_healthcheck_insecure_pwd_hash_configured(topology_st):
 
     standalone = topology_st.standalone
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    standalone.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     log.info('Configure an insecure passwordStorageScheme (SHA)')
     standalone.config.set('passwordStorageScheme', 'SHA')
 
@@ -154,6 +157,9 @@ def test_healthcheck_min_allowed_tls_version_too_low(topology_st):
 
     standalone = topology_st.standalone
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    standalone.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     standalone.enable_tls()
 
     # We have to update-crypto-policies to LEGACY, otherwise we can't set TLS1.0
@@ -210,6 +216,9 @@ def test_healthcheck_resolvconf_bad_file_perm(topology_st):
 
     standalone = topology_st.standalone
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    standalone.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     log.info('Change the /etc/resolv.conf file permissions to 444')
     os.chmod('/etc/resolv.conf', 0o444)
 
@@ -254,6 +263,9 @@ def test_healthcheck_pwdfile_bad_file_perm(topology_st):
     standalone = topology_st.standalone
     cert_dir = standalone.ds_paths.cert_dir
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    standalone.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     log.info('Change the /etc/dirsrv/slapd-{}/pwdfile.txt permissions to 000'.format(standalone.serverid))
     os.chmod('{}/pwdfile.txt'.format(cert_dir), 0o000)
 
@@ -291,10 +303,13 @@ def test_healthcheck_certif_expiring_within_30d(topology_st):
 
     standalone = topology_st.standalone
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    standalone.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     standalone.enable_tls()
 
     # Cert is valid two years from today, so we count the date that is within 30 days before certificate expiration
-    date_future = datetime.now() + timedelta(days=701)
+    date_future = datetime.now() + timedelta(days=702)
 
     with libfaketime.fake_time(date_future):
         run_healthcheck_and_flush_log(topology_st, standalone, RET_CODE, json=False)
@@ -329,10 +344,13 @@ def test_healthcheck_certif_expired(topology_st):
 
     standalone = topology_st.standalone
 
+    log.info('Set nsslapd-accesslog-logbuffering so it does not raise a warning')
+    standalone.config.set('nsslapd-accesslog-logbuffering', 'on')
+
     standalone.enable_tls()
 
     # Cert is valid two years from today, so we count the date that is after expiration
-    date_future = datetime.now() + timedelta(days=731)
+    date_future = datetime.now() + timedelta(days=732)
 
     with libfaketime.fake_time(date_future):
         run_healthcheck_and_flush_log(topology_st, standalone, RET_CODE, json=False)