Skip to content

Commit

Permalink
Issue 50834 - Incorrectly setting the NSS default SSL version max
Browse files Browse the repository at this point in the history
Description:  We've been using the wrong function to get the NSS max
              version We were calling SSL_VersionRangeGetSupported()
              which gets the versions NSS "can" handle, but
              SSL_VersionRangeGetDefault() gets the versions that
              are actually "enabled".

relates: https://pagure.io/389-ds-base/issue/50834

Reviewed by: mreynolds(one line commit rule)
  • Loading branch information
mreynolds389 committed Jan 20, 2020
1 parent 16f7b52 commit de5e4ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ldap/servers/slapd/ssl.c
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,7 @@ slapd_nss_init(int init_ssl __attribute__((unused)), int config_available __attr
char *certdir;
char emin[VERSION_STR_LENGTH], emax[VERSION_STR_LENGTH];
/* Get the range of the supported SSL version */
SSL_VersionRangeGetSupported(ssl_variant_stream, &enabledNSSVersions);
SSL_VersionRangeGetDefault(ssl_variant_stream, &enabledNSSVersions);

(void)slapi_getSSLVersion_str(enabledNSSVersions.min, emin, sizeof(emin));
(void)slapi_getSSLVersion_str(enabledNSSVersions.max, emax, sizeof(emax));
Expand Down

0 comments on commit de5e4ac

Please sign in to comment.