Skip to content

Commit

Permalink
Ticket 47704 - invalid sizelimits in aci group evaluation
Browse files Browse the repository at this point in the history
Bug Description:  aci group evaluation fails because of sizelimit exceeded
			but it is exceeded because it is -1476887876 or another
			negative integer becasue operation parameter are a union
			based on operation types and so for otehr than search
			the value is dependent on the operation params

Fix Description:   treat any negative integer like -1 (unlimited). A better fix
			would be to introduce a specific configuration param or
			to abondon the limit in group evaluation at all. But this
			could introduce backward compatibility problems and
			will be handled in ticket 47703 for newer versions

https://fedorahosted.org/389/ticket/47704

Reviewed by: Rich, thanks
(cherry picked from commit 377266e)
  • Loading branch information
elkris authored and nhosoi committed Mar 9, 2014
1 parent 2786adb commit e0092e3
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ldap/servers/plugins/acl/acl_ext.c
Expand Up @@ -835,6 +835,12 @@ acl_init_aclpb ( Slapi_PBlock *pb , Acl_PBlock *aclpb, const char *ndn, int copy
slapi_pblock_get( pb, SLAPI_SEARCH_SIZELIMIT, &aclpb->aclpb_max_member_sizelimit );
if ( aclpb->aclpb_max_member_sizelimit == 0 ) {
aclpb->aclpb_max_member_sizelimit = SLAPD_DEFAULT_LOOKTHROUGHLIMIT;
} else if ( aclpb->aclpb_max_member_sizelimit < -1 ) {
/* handle the case of a negtive size limit either set or due
* to bug bz1065971. The member size limit should be dropped,
* but for backward compatibility to the best we can
*/
aclpb->aclpb_max_member_sizelimit = -1;
}
slapi_pblock_get( pb, SLAPI_OPERATION_TYPE, &aclpb->aclpb_optype );

Expand Down

0 comments on commit e0092e3

Please sign in to comment.