Avoid using regex in ACL if possible.

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48175

• Created at 2015-04-30 07:59:58 by nhosoi (@nhosoi)
• Closed as Fixed
• Assigned to lkrispen (@elkris)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1236156

---

Too expensive for the acl operation?

$ egrep _re_ acl/*.[ch]
acl/acl.c:	re = slapi_re_comp( pat, &re_result );
acl/acl.c:	/* slapi_re_exec() returns 1 if the string p1 matches the last compiled
acl/acl.c:	rc = slapi_re_exec( re, realval, -1 /* no timelimit */ );
acl/acl.c:	slapi_re_free(re);

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-05-12 14:01:01

attachment

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-05-12 14:02:22

in a test scenario provided by qa the high cpu usage by the regex code could be confirmed [perf output attached]

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-05-12 14:09:57

attachment
0001-Ticket-48175-Avoid-using-regex-in-ACL-if-possible.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2015-05-12 21:48:06

You patch looks good!

Could you share the top result from the build which your patch is applied to? Thanks!

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-05-12 21:58:45

attachment

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-05-12 21:59:51

screenshot of perf top with fix attached

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2015-05-12 22:45:18

Replying to [comment:5 elkris]:

screenshot of perf top with fix attached

Thank you, Ludwig!! What a beautiful result!!

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-06-18 14:06:10

master:
commit 25c3b83

1.2.11:
commit 6024a77

[389-ds-bot]

Comment from lkrispen (@elkris) at 2015-06-18 14:11:19

1.3.3

commit 064df7b

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2015-06-26 23:42:14

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1236156

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2015-06-26 23:44:32

Note: 389-ds-base-1.3.4 was branched after this patch was pushed.

Closing this ticket as FIXED.

[389-ds-bot]

Comment from lkrispen (@elkris) at 2017-02-11 23:04:21

Metadata Update from @elkris:

• Issue assigned to elkris
• Issue set to the milestone: 1.2.11.33