PR - Ticket 49978 - Add CLI logging function for UI

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/49982

• Created at 2018-10-18 00:01:52 by mreynolds (@mreynolds389)
• Merged at 2018-10-18 16:44:16

---

Description:

Add a web browser console logging function to enforce
a consistent format and hide password values for CLI
commands.

Resolves: #3037

Reviewed by: ?

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-10-18 11:45:21

Missing ')' in the end

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-10-18 11:47:10

MIssing coma after 'do_winsync_agmt_init'

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-10-18 11:54:18

The rest looks good. :)

And what do you think regarding @kenoh comment? I think it makes sence to have a switch for the logging.
#3037#comment-536490

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-10-18 14:25:53

The rest looks good. :)
And what do you think regarding @kenoh comment? I think it makes sence to have a switch for the logging.
#3037#comment-536490

There's no overhead in having the logging, and I added a check for the presence of console.log() in log_cmd(). So it will be safe for obscure browsers that we technically would NOT support anyway ;-) We only support Firefox, Chrome, and MS Edge - all of which support console.log().

So I prefer to keep it "always on" and not add a hidden checkbox in the UI somewhere. I'll get the rest of the changes applied shortly

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-10-18 14:30:01

rebased onto 34428dbf7b9032a718c1e8488e90385b6e10fb4d

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-10-18 14:31:09

rebased onto 9c05b39394882d48c4893de9355c8e4e0871734e

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-10-18 14:51:33

Please review :-)

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-10-18 16:01:18

Missing coma after 'do_agmt_init'...

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-10-18 16:03:30

rebased onto aaf517c

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-10-18 16:12:33

okay, ack :)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-10-18 16:44:17

Pull-Request has been merged by mreynolds389

[389-ds-bot]

Patch
49982.patch