Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 49761 - Fix CI test suite issues #3832

Closed
389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Closed

PR - Issue 49761 - Fix CI test suite issues #3832

389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50777

  • Created at 2019-12-10 19:21:17 by bsmejkal
  • Merged at 2020-01-13 13:25:41

Description:
Fixing failing ticket48755_test.py, so it would pass nightly tests.
Also moved the test from tickets to suites/replication/regressions_test.py

This code is NOT IN MERGEABLE state.
The test passes on Fedora, RHEL7 and RHEL8
but I could use an advice with how to replace "search_s"
so the test wouldn't use deprecated features, please.
Thanks.

Relates: Resolves: #1815
Relates: Resolves: #2820

Reviewed by: vashirov (Thanks!)

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

389-ds-bot commented Sep 13, 2020

Comment from spichugi (@droideck) at 2019-12-12 18:54:37

search_s won't be deprecated itself. We just want to get rid of the Entry API.
#3656
So we are free to use it in special cases. This one is special, I think. The case when we want to get all server entries including hidden and tombstones.

The code LGTM! Ack

@389-ds-bot
Copy link
Author

Comment from bsmejkal at 2020-01-13 13:23:50

rebased onto b8a922e

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2020-01-13 13:25:41

Pull-Request has been merged by droideck

@389-ds-bot
Copy link
Author

Patch
50777.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant