Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat for entry api to all deprecation and _s interfaces to be accessible. #3656

Open
389-ds-bot opened this issue Sep 13, 2020 · 2 comments
Labels
lib389 Involves lib389 librabry
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50600


Issue Description

Lib389 has a legacy Entry interface. It's implemented in a really complex and difficult to understand manner. This interface is deprecated, and we have wanted to remove it for sometime. In wanting to remove it, we have tried to ask people to stop using the _s apis because it adds more techdebt on an interface we don't want.

Developers and QE want to be able to control certain ldap operations though. They want to use the _s apis. But this would make it harder and harder to remove this piece of techdebt.

I have resisted people using the _s ldap apis because I don't want more usage of Entry, but we also can't remove it easily because we would break some legacy tests.

As a middle ground it was suggested that:

  • We remove the meta layer that turns ldap raw calls into Entry wrapping and unwrapping calls.
  • We add compat functions for _s_entry that access and does the entry wrap and unwrap
  • we rework dsldapobject to use the _s calls directly without Entry (IE the dict ldap api).

This way people could use the ldap calls on dirsrv they want for tests, and we move closer to identifying and removing the Entry api.

@389-ds-bot 389-ds-bot added the lib389 Involves lib389 librabry label Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the 1.4 backlog milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-19 17:40:37

Metadata Update from @mreynolds389:

  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Issue set to the milestone: 1.4.2
  • Issue tagged with: lib389

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-03-04 16:34:08

Metadata Update from @mreynolds389:

  • Issue priority set to: normal
  • Issue set to the milestone: 1.4 backlog (was: 1.4.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib389 Involves lib389 librabry
Projects
None yet
Development

No branches or pull requests

2 participants