wildcards in rootdn-allow-ip attribute are not accepted

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50800

• Created at 2019-12-28 19:46:28 by yrro
• Closed at 2020-03-20 03:58:15 as fixed
• Assigned to mreynolds (@mreynolds389)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1807537

---

Issue Description

Attempting to use a wildcard in the rootdn-allow-ip attribute of the rootdn_access plugin causes the server to fail to start:

ERR - rootdn-access-control-plugin - rootdn_load_config - IP address contains invalid characters (127.*), skipping
ERR - rootdn-access-control-plugin - rootdn_init - Unable to load plug-in configuration
ERR - plugin_setup - Init function "rootdn_init" for "RootDN Access Control" plugin in library "librootdn-access-plugin" failed
ERR - load_plugin_entry - Unable to load plugin "cn=RootDN Access Control,cn=plugins,cn=config"

The use of wildcards is documented and was allowed when the plugin was originally added, but the changes in 48027 unintentionally broke the parsing of values containing a *.

[389-ds-bot]

Comment from yrro at 2019-12-28 20:33:01

Quick/untested fix at https://pagure.io/fork/yrro/389-ds-base/diff/master..rootdn-allow-ip-wildcards.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-12-30 00:51:57

Hey @yrro did you want to make this fix a PR so that we can comment and discuss it there?

Thanks for reporting the issue by the way :)

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-12-30 00:51:58

Metadata Update from @Firstyear:

• Custom field origin adjusted to None
• Custom field reviewstatus adjusted to None

[389-ds-bot]

Comment from yrro at 2019-12-30 15:39:08

Here you go: #3857

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-01-02 01:35:25

Thanks! I'll review further there.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-01-09 17:57:32

Metadata Update from @mreynolds389:

• Issue set to the milestone: 1.3.10

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-02-12 16:20:59

Metadata Update from @mreynolds389:

• Issue set to the milestone: 1.4.1 (was: 1.3.10)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-02-12 16:21:47

Metadata Update from @mreynolds389:

• Issue priority set to: major

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-02-26 16:08:07

Metadata Update from @mreynolds389:

• Issue set to the milestone: 1.3.10 (was: 1.4.1)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-02-26 16:09:01

Metadata Update from @mreynolds389:

• Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1807537

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-02-26 16:09:02

Issue linked to Bugzilla: Bug 1807537

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-03-16 21:39:54

Metadata Update from @mreynolds389:

• Issue assigned to mreynolds389

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-03-20 02:27:44

Thanks for the original patch @yrro

I had to make a few changes to get the test case to run correctly, so I ended up creating a new PR

#4018

Please review...

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-03-20 03:49:37

Commit c4befd63 relates to this ticket

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-03-20 03:58:16

Commit c4befd6 relates to this ticket

6e997ea..d8f2994 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

31be5e4..b811ee0 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

811db90..6ced3f5 389-ds-base-1.3.10 -> 389-ds-base-1.3.10

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-03-20 03:58:17

Metadata Update from @mreynolds389:

• Issue close_status updated to: fixed
• Issue status updated to: Closed (was: Open)