PR - Issue 50800 - Fix parsing of wildcards in rootdn-allow-ip attribute

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50803

• Created at 2019-12-30 15:38:42 by yrro
• Merged at 2020-05-01 15:37:51

---

The changes in ticket 48027 caused IP addresses containing wildcards to
be rejected.

This changes the set of allowable characters to match that used for the
rootdn-deny-ip attribute.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-01-02 01:35:59

@mreynolds389 You seem to be the person who knows the most about this area (I think), did you mind taking a look? How would we construct a test to validate this behaviour?

[389-ds-bot]

Comment from tbordaz (@tbordaz) at 2020-01-06 11:32:11

Thanks @yrro for the finding and the patch. IMHO the fix looks good, it was a missing allowed wildcard that only affects the branch checking ip address. The 'host' branch accepts wildcard. Let's wait for @mreynolds389 final approval.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-01-06 15:16:55

Not sure why the "*" was removed. @yrro did you confirm if this change works for you? If it works, then this gets my ack.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-01-07 03:13:42

@mreynolds389 Is it also worth getting some tests for this later? I'm not sure how we'd do it in py.test, we'd probably need @vashirov's advice here.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-01-09 10:18:06

We have a test suite for root DN plugin at https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/plugins/rootdn_plugin_test.py

test_rootdn_config_validate can be extended with this particular case.

[389-ds-bot]

Comment from yrro at 2020-01-16 14:41:42

1 new commit added

• WIP tests

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-01-22 02:41:58

@yrro Is there anything we can do to help you with the test case development so we can merge this fix :)

[389-ds-bot]

Comment from yrro at 2020-01-22 10:43:52

I'm sorry to say I just haven't had time to set up an environment to build and run the tests yet, that's all.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-05-01 15:37:42

This was a fixed in a different PR. Thanks for the contribution, closing this one...

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-05-01 15:37:51

Pull-Request has been closed by mreynolds389

[389-ds-bot]

Patch
50803.patch