Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New compiler failures on Fedora 33 #4093

Closed
389-ds-bot opened this issue Sep 13, 2020 · 1 comment
Closed

New compiler failures on Fedora 33 #4093

389-ds-bot opened this issue Sep 13, 2020 · 1 comment
Assignees
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/51040


Issue Description

warning: Tag 'PERL_PATH' at line 2058 of file '/root/source/BUILD/docs/slapi.doxy' has become obsolete.
         To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'MSCGEN_PATH' at line 2080 of file '/root/source/BUILD/docs/slapi.doxy' has become obsolete.
         To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
@389-ds-bot 389-ds-bot added this to the 1.4.3 milestone Sep 13, 2020
@mreynolds389 mreynolds389 modified the milestones: 1.4.3, 2.0.0 Nov 3, 2020
@mreynolds389
Copy link
Contributor

Here are all the comilier errors and warnings:

ldap/servers/plugins/replication/repl_extop.c: In function 'multimaster_extop_EndNSDS50ReplicationRequest':
ldap/servers/plugins/replication/repl_extop.c:1181:44: warning: passing argument 1 of 'replica_subentry_check' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1181 | replica_subentry_check(replica_get_root(r), replica_get_rid(r));
| ^~~~~~~~~~~~~~~~~~~
In file included from ldap/servers/plugins/replication/repl_extop.c:16:
ldap/servers/plugins/replication/repl5.h:680:38: note: expected 'Slapi_DN *' {aka 'struct slapi_dn *'} but argument is of type 'const Slapi_DN *' {aka 'const struct slapi_dn *'}
680 | int replica_subentry_check(Slapi_DN *repl_root, ReplicaId rid);
| ~~~~~~~~~~^~~~~~~~~

  ldap/servers/plugins/replication/cl5_api.c: In function 'cl5ImportLDIF':

ldap/servers/plugins/replication/cl5_api.c:686:12: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
686 | return rc;
| ^~

  In file included from /usr/include/string.h:519,
             from ldap/servers/plugins/acl/acl.h:24,
             from ldap/servers/plugins/acl/aclparse.c:14:

In function 'strncpy',
inlined from '__aclp__parse_aci' at ldap/servers/plugins/acl/aclparse.c:270:17,
inlined from 'acl_parse' at ldap/servers/plugins/acl/aclparse.c:98:24:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' output truncated before terminating nul copying 1 byte from a string of the same length [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'strncpy',
inlined from '__aclp__parse_aci' at ldap/servers/plugins/acl/aclparse.c:368:17,
inlined from 'acl_parse' at ldap/servers/plugins/acl/aclparse.c:98:24:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' output truncated before terminating nul copying 1 byte from a string of the same length [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'strncpy',
inlined from '__aclp__parse_aci' at ldap/servers/plugins/acl/aclparse.c:436:17,
inlined from 'acl_parse' at ldap/servers/plugins/acl/aclparse.c:98:24:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' output truncated before terminating nul copying 1 byte from a string of the same length [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  In function 'strncpy',
inlined from 'main' at ldap/servers/snmp/main.c:151:17:

/usr/include/bits/string_fortified.h:106:10: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^
ldap/servers/snmp/main.c: In function 'main':
ldap/servers/snmp/main.c:151:63: note: length computed here
151 | strncpy((char *)log_hdl->token, agent_logdir, strlen(agent_logdir) + 1);

In file included from /usr/include/string.h:519,
from ldap/servers/snmp/main.c:15:
In function 'strncpy',
inlined from 'main' at ldap/servers/snmp/main.c:151:17:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ldap/servers/snmp/main.c: In function 'main':
ldap/servers/snmp/main.c:151:63: note: length computed here
151 | strncpy((char *)log_hdl->token, agent_logdir, strlen(agent_logdir) + 1);
| ^~~~~~~~~~~~~~~~~~~~

  In function 'strncpy',
inlined from 'basicInit' at ldap/servers/slapd/tools/ldclt/ldclt.c:1164:9:

/usr/include/bits/string_fortified.h:106:10: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^
ldap/servers/slapd/tools/ldclt/ldclt.c: In function 'basicInit':
ldap/servers/slapd/tools/ldclt/ldclt.c:1164:9: note: length computed here
1164 | strncpy(mctx.attRefDef, mctx.attrpl + i + 1, strlen(mctx.attrpl + i + 1));
| ^
In function 'strncpy',
inlined from 'basicInit' at ldap/servers/slapd/tools/ldclt/ldclt.c:1193:9:
/usr/include/bits/string_fortified.h:106:10: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^
ldap/servers/slapd/tools/ldclt/ldclt.c: In function 'basicInit':
ldap/servers/slapd/tools/ldclt/ldclt.c:1193:9: note: length computed here
1193 | strncpy(mctx.attrplFile, mctx.attrpl + i + 1, strlen(mctx.attrpl + i + 1));
| ^
In function 'strcat',
inlined from 'buildArgListString' at ldap/servers/slapd/tools/ldclt/ldclt.c:2195:5,
inlined from 'main' at ldap/servers/slapd/tools/ldclt/ldclt.c:2238:16:
/usr/include/bits/string_fortified.h:129:10: warning: '__builtin_strcpy' writing 1 or more bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
129 | return __builtin___strcat_chk (__dest, __src, __bos (__dest));

In file included from /usr/include/string.h:519,
from ldap/servers/slapd/tools/ldclt/threadMain.c:122:
In function 'strncpy',
inlined from 'msgIdAdd' at ldap/servers/slapd/tools/ldclt/threadMain.c:538:5:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'strncpy',
inlined from 'msgIdAdd' at ldap/servers/slapd/tools/ldclt/threadMain.c:540:5:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  In file included from /usr/include/string.h:519,
             from ldap/servers/slapd/tools/ldclt/ldclt.c:36:

In function 'strncpy',
inlined from 'basicInit' at ldap/servers/slapd/tools/ldclt/ldclt.c:1164:9:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ldap/servers/slapd/tools/ldclt/ldclt.c: In function 'basicInit':
ldap/servers/slapd/tools/ldclt/ldclt.c:1164:9: note: length computed here
1164 | strncpy(mctx.attRefDef, mctx.attrpl + i + 1, strlen(mctx.attrpl + i + 1));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/string.h:519,
from ldap/servers/slapd/tools/ldclt/ldclt.c:36:
In function 'strncpy',
inlined from 'basicInit' at ldap/servers/slapd/tools/ldclt/ldclt.c:1193:9:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ldap/servers/slapd/tools/ldclt/ldclt.c: In function 'basicInit':
ldap/servers/slapd/tools/ldclt/ldclt.c:1193:9: note: length computed here
1193 | strncpy(mctx.attrplFile, mctx.attrpl + i + 1, strlen(mctx.attrpl + i + 1));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/string.h:519,
from ldap/servers/slapd/tools/ldclt/ldclt.c:36:
In function 'strcat',
inlined from 'buildArgListString' at ldap/servers/slapd/tools/ldclt/ldclt.c:2195:5:
/usr/include/bits/string_fortified.h:129:10: warning: 'strcpy' offset 0 is out of the bounds [0, 0] [-Warray-bounds]
129 | return __builtin___strcat_chk (__dest, __src, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  In file included from /usr/include/string.h:519,
             from ldap/servers/plugins/syntaxes/string.c:17:

In function 'strncpy',
inlined from 'string_filter_sub' at ldap/servers/plugins/syntaxes/string.c:345:13:
/usr/include/bits/string_fortified.h:106:10: warning: 'strncpy' specified bound 8192 equals destination size [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  warning: Tag 'TCL_SUBST' at line 237 of file '/builddir/build/BUILD/389-ds-base-2.0.1/docs/slapi.doxy' has become obsolete.
     To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"

warning: Tag 'PERL_PATH' at line 2058 of file '/builddir/build/BUILD/389-ds-base-2.0.1/docs/slapi.doxy' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'MSCGEN_PATH' at line 2080 of file '/builddir/build/BUILD/389-ds-base-2.0.1/docs/slapi.doxy' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: tag INPUT: input source 'docs/job-safety.md' does not exist
warning: source docs/job-safety.md is not a readable file or directory... skipping.

@mreynolds389 mreynolds389 self-assigned this Jan 23, 2021
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 27, 2021
Description:  Update the doxy file (doxygen), fix compiler warnings
              (x86_64, arm, and s390x), and update Rust cargo file.

relates: 389ds#4093

Reviewed by: firstyear, spichugi, & progier(Thanks!!!)
mreynolds389 added a commit that referenced this issue Jan 27, 2021
Description:  Update the doxy file (doxygen), fix compiler warnings
              (x86_64, arm, and s390x), and update Rust cargo file.

relates: #4093

Reviewed by: firstyear, spichugi, & progier(Thanks!!!)
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jun 16, 2021
Bug Description:  Once some compiler warnings were fixed it
                  accidentally fixed the modrdn behavior.  Previously
                  the modrdn code accidentally ignored errors that the
                  test case was taking for granted.  Once these checks
                  were properly inforced the teset case started to fail.

Fix Description:  Revise test case to "properly" check modrdn operations
                  by creating the Managed Entry before assignign it to
                  an entry, and then check for the revise managhed entry
                  DN after the modrdn takes place.

                  Also, improved CI debugging logging settings

relates: 389ds#4093

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jun 16, 2021
Bug Description:  Once some compiler warnings were fixed it
                  accidentally fixed the modrdn behavior.  Previously
                  the modrdn code accidentally ignored errors that the
                  test case was taking for granted.  Once these checks
                  were properly inforced the teset case started to fail.

Fix Description:  Revise test case to "properly" check modrdn operations
                  by creating the Managed Entry before assignign it to
                  an entry, and then check for the revise managhed entry
                  DN after the modrdn takes place.

                  Also, improved CI debugging logging settings

relates: #4093

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jun 16, 2021
Bug Description:  Once some compiler warnings were fixed it
                  accidentally fixed the modrdn behavior.  Previously
                  the modrdn code accidentally ignored errors that the
                  test case was taking for granted.  Once these checks
                  were properly inforced the teset case started to fail.

Fix Description:  Revise test case to "properly" check modrdn operations
                  by creating the Managed Entry before assignign it to
                  an entry, and then check for the revise managhed entry
                  DN after the modrdn takes place.

                  Also, improved CI debugging logging settings

relates: #4093

Reviewed by: spichugi(Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants