Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib389 - remove python.six #4105

Closed
389-ds-bot opened this issue Sep 13, 2020 · 4 comments · Fixed by #4456
Closed

lib389 - remove python.six #4105

389-ds-bot opened this issue Sep 13, 2020 · 4 comments · Fixed by #4456
Assignees
@droideck
Milestone
1.4.4

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/51052

Issue Description

We no longer use python 2, we can remove all the python six imports and code:

  • dirsrvtests/tests/suites/schema/schema_test.py:import six
  • src/lib389/lib389/agreement.py:import six
  • src/lib389/lib389/utils.py:import six
  • src/lib389/lib389/_entry.py:import six
  • src/lib389/lib389/init.py:import six
  • src/lib389/lib389/tests/config.py:import six
  • src/lib389/lib389/mappingTree.py:import six
  • src/lib389/lib389/_ldifconn.py:import six
  • src/lib389/build/lib/lib389/tools.py: import six.moves.urllib.request
  • src/lib389/build/lib/lib389/tools.py: import six.moves.urllib.parse
  • src/lib389/build/lib/lib389/tools.py: import six.moves.urllib.error
  • src/lib389/build/lib/lib389/tools.py: import six
  • src/lib389/build/lib/lib389/agreement.py:import six
  • src/lib389/build/lib/lib389/utils.py:import six
  • src/lib389/build/lib/lib389/_entry.py:import six
  • src/lib389/build/lib/lib389/init.py:import six
  • src/lib389/build/lib/lib389/tests/config.py:import six
  • src/lib389/build/lib/lib389/mappingTree.py:import six
  • src/lib389/build/lib/lib389/_ldifconn.py:import six
@389-ds-bot 389-ds-bot added this to the 1.4.4 milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-04-30 17:29:35

Metadata Update from @mreynolds389:

  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Issue priority set to: normal
  • Issue set to the milestone: 1.4.4

@droideck droideck self-assigned this Nov 23, 2020
@droideck droideck mentioned this issue Nov 23, 2020
Merged
droideck added a commit that referenced this issue Nov 24, 2020
@droideck
Issue 4105 - Remove python.six from lib389 (#4456)
4d5915f 
Description: We no longer use python 2, we can remove all the python-six
imports and replace code with Python 3 support only.

Fixes: #4105

Reviewed by: @mreynolds389 @Firstyear (Thanks!)
droideck added a commit that referenced this issue Nov 24, 2020
@droideck
Issue 4105 - Remove python.six from lib389 (#4456)
8657fe4 
Description: We no longer use python 2, we can remove all the python-six
imports and replace code with Python 3 support only.

Fixes: #4105

Reviewed by: @mreynolds389 @Firstyear (Thanks!)
@droideck
Copy link
Member

61738d3..4d5915f master -> origin/master
5eacadd..8657fe4 389-ds-base-1.4.4 -> 389-ds-base-1.4.4

tbordaz pushed a commit to tbordaz/389-ds-base that referenced this issue Nov 26, 2020
@droideck @tbordaz
Issue 4105 - Remove python.six from lib389 (389ds#4456)
3f7d945 
Description: We no longer use python 2, we can remove all the python-six
imports and replace code with Python 3 support only.

Fixes: 389ds#4105

Reviewed by: @mreynolds389 @Firstyear (Thanks!)
@mreynolds389
Copy link
Contributor

This broke FreeIPA install:

See: #4468

Reopening ticket...

@mreynolds389 mreynolds389 reopened this Nov 30, 2020
mreynolds389 added a commit that referenced this issue Nov 30, 2020
@mreynolds389
Issue 4105 - Remove python.six (fix regression)
74170d7 
Description:  The switch off of six StringIO was not correctly ported,
              and an object was assigned to a variable instead of the
              variable being initialized with a new instance of the
              object.

Fixes: #4105

Reviewed by: mreynolds(one line commit rule)
@mreynolds389
Copy link
Contributor

a5029c8..782e6c1 master -> master
806feba..74170d7 389-ds-base-1.4.4 -> 389-ds-base-1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droideck droideck

Labels
None yet
Projects
None yet
Milestone
1.4.4
Development

Successfully merging a pull request may close this issue.

Issue 4105 - Remove python.six from lib389
3 participants
@mreynolds389 @droideck @389-ds-bot