Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve csngen testing thread #4507

Closed
mreynolds389 opened this issue Dec 17, 2020 · 2 comments · Fixed by #4508
Closed

Improve csngen testing thread #4507

mreynolds389 opened this issue Dec 17, 2020 · 2 comments · Fixed by #4508
Assignees
@mreynolds389
Labels
CI test Involves lib389 CI test
Milestone
1.4.3

Comments

@mreynolds389
Copy link
Contributor

Issue Description
A task was added to test csn generation with time skew. This was just for testing, but it caused the CI test to run over 10 minutes,when it should really only takes less than 30 seconds to run.

The csngen task should be checking for server shutdown so it doesn't hang the server.
@mreynolds389 mreynolds389 added the CI test Involves lib389 CI test label Dec 17, 2020
@mreynolds389 mreynolds389 added this to the 1.4.3 milestone Dec 17, 2020
@mreynolds389 mreynolds389 self-assigned this Dec 17, 2020
@mreynolds389 mreynolds389 mentioned this issue Dec 17, 2020
Merged
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 5, 2021
@mreynolds389
Issue 4507 - Improve csngen testing task
bfa125d 
Description:  Once the csngen testing task is created, it will not stop for 10 minutes
              even if you attempt to stop the server.  This is adding 10 minutes to
              the CI testing runs.

              Improved this task to check for the server shutdown, an moved the csngen
              test to the bottom of the file so it is executed last so it does not
              interfere with other tests

Fixes: 389ds#4507

Reviewed by: tbordaz(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 5, 2021
@mreynolds389
Issue 4507 - Improve csngen testing task (#4508)
a161815 
Description:  Once the csngen testing task is created, it will not stop for 10 minutes
              even if you attempt to stop the server.  This is adding 10 minutes to
              the CI testing runs.

              Improved this task to check for the server shutdown, an moved the csngen
              test to the bottom of the file so it is executed last so it does not
              interfere with other tests

Fixes: #4507

Reviewed by: tbordaz(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 5, 2021
@mreynolds389
Issue 4507 - Improve csngen testing task (#4508)
b0cc338 
Description:  Once the csngen testing task is created, it will not stop for 10 minutes
              even if you attempt to stop the server.  This is adding 10 minutes to
              the CI testing runs.

              Improved this task to check for the server shutdown, an moved the csngen
              test to the bottom of the file so it is executed last so it does not
              interfere with other tests

Fixes: #4507

Reviewed by: tbordaz(Thanks!)
@mreynolds389
Copy link
Contributor Author

c5dfc28..b0cc338 389-ds-base-1.4.4 -> 389-ds-base-1.4.4

mreynolds389 added a commit that referenced this issue Jan 5, 2021
@mreynolds389
Issue 4507 - Improve csngen testing task (#4508)
7609837 
Description:  Once the csngen testing task is created, it will not stop for 10 minutes
              even if you attempt to stop the server.  This is adding 10 minutes to
              the CI testing runs.

              Improved this task to check for the server shutdown, an moved the csngen
              test to the bottom of the file so it is executed last so it does not
              interfere with other tests

Fixes: #4507

Reviewed by: tbordaz(Thanks!)
@mreynolds389
Copy link
Contributor Author

a35c242..7609837 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

Labels
CI test Involves lib389 CI test
Projects
None yet
Milestone
1.4.3
Development

Successfully merging a pull request may close this issue.

Issue 4507 - Improve csngen testing task mreynolds389/389-ds-base
1 participant
@mreynolds389