Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS crash in deref plugin while dereferencing an entry that exists but that is not returned by internal search #4521

Closed
tbordaz opened this issue Jan 8, 2021 · 1 comment
Closed

DS crash in deref plugin while dereferencing an entry that exists but that is not returned by internal search #4521

tbordaz opened this issue Jan 8, 2021 · 1 comment
Milestone
1.3.10

Comments

@tbordaz
Copy link
Contributor

tbordaz commented Jan 8, 2021 •
edited

Issue Description
Deref control dereference a set of attributes that are present in the returned set of entries. Each attribute value is assume to be a DN of an entry. if for some reason the deref plugin can not retrieve (internal search) the entry, the server crash.

Package Version and Platform:
all versions

Steps to Reproduce
Testcase to be provided

Expected results
The deref control should be handled without a crash even if the returned entries a corrupted
@tbordaz tbordaz added the needs triage The issue will be triaged during scrum label Jan 8, 2021
@tbordaz tbordaz mentioned this issue Jan 11, 2021
Merged
@tbordaz tbordaz added this to the 1.3.10 milestone Jan 11, 2021
@tbordaz tbordaz removed the needs triage The issue will be triaged during scrum label Jan 11, 2021
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Jan 11, 2021
@tbordaz
Issue 4521 - DS crash in deref plugin if dereferenced entry exists bu…
e9f7944 
…t is not returned by internal search

Bug description:
	For each returned entry, deref plugin dereferences some attribute values that refer to entries.
	To do this it does an internal search (scope base) with each attribute values.
	Deref plugin assumes that if internal search succeeds, a single entry is returned.
	It exists cases (not identified) where internal search succeeds but returns no entry.
	In such case (search succeeds but no entry returned) the server crash.
	Note: wonder if DB deadlock could lead to such situation.

Fix description:
	Make a hardening fix that logs warning in such case

relates: 389ds#4521

Reviewed by: Mark Reynolds (thanks)

Platforms tested: F31
tbordaz added a commit that referenced this issue Jan 11, 2021
@tbordaz
Issue 4521 - DS crash in deref plugin if dereferenced entry exists bu…
acaf223 
…t is not returned by internal search (#4525)

Bug description:
	For each returned entry, deref plugin dereferences some attribute values that refer to entries.
	To do this it does an internal search (scope base) with each attribute values.
	Deref plugin assumes that if internal search succeeds, a single entry is returned.
	It exists cases (not identified) where internal search succeeds but returns no entry.
	In such case (search succeeds but no entry returned) the server crash.
	Note: wonder if DB deadlock could lead to such situation.

Fix description:
	Make a hardening fix that logs warning in such case

relates: #4521

Reviewed by: Mark Reynolds (thanks)

Platforms tested: F31
tbordaz added a commit that referenced this issue Jan 11, 2021
@tbordaz
Issue 4521 - DS crash in deref plugin if dereferenced entry exists bu…
f221b9b 
…t is not returned by internal search (#4525)

Bug description:
	For each returned entry, deref plugin dereferences some attribute values that refer to entries.
	To do this it does an internal search (scope base) with each attribute values.
	Deref plugin assumes that if internal search succeeds, a single entry is returned.
	It exists cases (not identified) where internal search succeeds but returns no entry.
	In such case (search succeeds but no entry returned) the server crash.
	Note: wonder if DB deadlock could lead to such situation.

Fix description:
	Make a hardening fix that logs warning in such case

relates: #4521

Reviewed by: Mark Reynolds (thanks)

Platforms tested: F31
tbordaz added a commit that referenced this issue Jan 11, 2021
@tbordaz
Issue 4521 - DS crash in deref plugin if dereferenced entry exists bu…
79e924b 
…t is not returned by internal search (#4525)

Bug description:
	For each returned entry, deref plugin dereferences some attribute values that refer to entries.
	To do this it does an internal search (scope base) with each attribute values.
	Deref plugin assumes that if internal search succeeds, a single entry is returned.
	It exists cases (not identified) where internal search succeeds but returns no entry.
	In such case (search succeeds but no entry returned) the server crash.
	Note: wonder if DB deadlock could lead to such situation.

Fix description:
	Make a hardening fix that logs warning in such case

relates: #4521

Reviewed by: Mark Reynolds (thanks)

Platforms tested: F31
tbordaz added a commit that referenced this issue Jan 11, 2021
@tbordaz
Issue 4521 - DS crash in deref plugin if dereferenced entry exists bu…
d8963a0 
…t is not returned by internal search (#4525)

Bug description:
	For each returned entry, deref plugin dereferences some attribute values that refer to entries.
	To do this it does an internal search (scope base) with each attribute values.
	Deref plugin assumes that if internal search succeeds, a single entry is returned.
	It exists cases (not identified) where internal search succeeds but returns no entry.
	In such case (search succeeds but no entry returned) the server crash.
	Note: wonder if DB deadlock could lead to such situation.

Fix description:
	Make a hardening fix that logs warning in such case

relates: #4521

Reviewed by: Mark Reynolds (thanks)

Platforms tested: F31
@tbordaz
Copy link
Contributor Author

tbordaz commented Jan 11, 2021

89367c6..acaf223 master
62ba2a2..f221b9b 389-ds-base-1.4.4
0acda48..79e924b 389-ds-base-1.4.3
f917145..d8963a0 389-ds-base-1.3.10

@tbordaz tbordaz closed this as completed Jan 11, 2021
@tbordaz tbordaz changed the title DS crash in deref plugin while dereferencing an attribute with invalid value DS crash in deref plugin while dereferencing an entry that exists but that is not returned by internal search Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.10
Development

No branches or pull requests
1 participant
@tbordaz