Retro Changelog is not trimming changes #4869
Comments
|
Maybe we need to look at the tests too. Is there a test that should have caught this? Whatever the answer (yes or no), we need to investigate. Is it |
|
@keestux - agreed our tests are not robust enough to pick up on this failure |
|
@mreynolds389 What's your comment on the typo? Should we make a separate issue for it? |
|
|
@vashirov What? Now that is a good way to confuse users. |
Yes, we know. But sadly some of these decisions were made many years ago and it can be hard to change in existing releases. We do want to improve these. IMO I'd love to rename these - are we still able to make breaking changes for 2.x @mreynolds389 ? A part of the issue here is our tests can't easily manipulate "time" to check this, but I'd be open to some other ideas. |
mreynolds389
added
Need BZ
No can't make this change now, but it's not needed IMHO. People "should" be using the python CLI & UI to make these config changes - so the attribute names really shouldn't matter. It's only a issue for the rare cases where the dse.ldif needs to be manually edited. Anyway time for me to start looking at the real bug here... |
Bug Description: Monotonic clocks were used to check if an entry was old
enough to be trimmed, but the real system time should be
used. So entries were never trimmed from the changelog.
Fix Description: Make sure monotonic clocks are only used for the
trimming interval, and real time clocks are used
for entry age.
relates: 389ds#4869
Reviewed by: firstyear(Thanks!)
Bug Description: Monotonic clocks were used to check if an entry was old
enough to be trimmed, but the real system time should be
used. So entries were never trimmed from the changelog.
Fix Description: Make sure monotonic clocks are only used for the
trimming interval, and real time clocks are used
for entry age.
relates: #4869
Reviewed by: firstyear(Thanks!)
Bug Description: Monotonic clocks were used to check if an entry was old
enough to be trimmed, but the real system time should be
used. So entries were never trimmed from the changelog.
Fix Description: Make sure monotonic clocks are only used for the
trimming interval, and real time clocks are used
for entry age.
relates: #4869
Reviewed by: firstyear(Thanks!)
Bug Description: Monotonic clocks were used to check if an entry was old
enough to be trimmed, but the real system time should be
used. So entries were never trimmed from the changelog.
Fix Description: Make sure monotonic clocks are only used for the
trimming interval, and real time clocks are used
for entry age.
relates: #4869
Reviewed by: firstyear(Thanks!)
Bug Description: Monotonic clocks were used to check if an entry was old
enough to be trimmed, but the real system time should be
used. So entries were never trimmed from the changelog.
Fix Description: Make sure monotonic clocks are only used for the
trimming interval, and real time clocks are used
for entry age.
relates: #4869
Reviewed by: firstyear(Thanks!)
Issue Description
Retro changelog is not trimming changes under some circumstances because we are mixing monotonic and utc times
[11/Aug/2021:11:01:49.792450548 +0200] - DEBUG - DSRetroclPlugin - cltrim: ldrc=0, first_time=1622032141, cur_time=3702600
[11/Aug/2021:11:01:49.842339467 +0200] - DEBUG - DSRetroclPlugin - retrocl_housekeeping - changelog does not need to be trimmed
[11/Aug/2021:11:06:49.953401407 +0200] - DEBUG - DSRetroclPlugin - cltrim: ldrc=0, first_time=1622032141, cur_time=3702900
[11/Aug/2021:11:06:50.012249703 +0200] - DEBUG - DSRetroclPlugin - retrocl_housekeeping - changelog does not need to be trimmed
Look at cur_time. That is the "uptime" of the system, not UTC.
[root@linge ~]# uptime
11:21:42 up 42 days, 20:49, 2 users, load average: 0.15, 0.14, 0.16
In the retro changelog code (trim_changelog) we are using the same monotonic time for the interval and checking for the age of an entry. We need to use the current time when checking the age and not the monotonic time.
The text was updated successfully, but these errors were encountered: