Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockpit_present() assumes rpm is used #5351

Closed
tjaalton opened this issue Jun 22, 2022 · 2 comments
Closed

cockpit_present() assumes rpm is used #5351

tjaalton opened this issue Jun 22, 2022 · 2 comments
Assignees
Labels
cockpit Cockpit UI Plugin

Comments

@tjaalton
Copy link
Contributor

Issue Description
Running 'dsctl ds cockpit enable' fails on Debian, because it's trying to use rpm to see if 'cockpit' is installed.

Package Version and Platform:

  • Platform: Debian based distros

Steps to Reproduce

dsctl ds cockpit enable

/bin/sh: 1: rpm: not found
Error: The 'cockpit' package is not installed on this system

cockpit_present() should detect that the distro is based on Debian, and use 'dpkg-query -s cockpit' instead (the command returns an error if a package is not installed, and package metadata if it is)

@tjaalton tjaalton added the needs triage The issue will be triaged during scrum label Jun 22, 2022
@mreynolds389
Copy link
Contributor

@tjaalton - On Debian does this command still work:

sudo systemctl enable --now cockpit.socket

@tjaalton
Copy link
Contributor Author

I don't see a reason why it wouldn't work, can't check myself now.

@mreynolds389 mreynolds389 self-assigned this Jan 20, 2023
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 23, 2023
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: 389ds#5607
relates: 389ds#5351
relates: 389ds#5611

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 23, 2023
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: #5607
relates: #5351
relates: #5611

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 23, 2023
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: #5607
relates: #5351
relates: #5611

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 23, 2023
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: #5607
relates: #5351
relates: #5611

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 23, 2023
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: #5607
relates: #5351
relates: #5611

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 23, 2023
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: #5607
relates: #5351
relates: #5611

Reviewed by: spichugi(Thanks!)
@mreynolds389 mreynolds389 added cockpit Cockpit UI Plugin and removed needs triage The issue will be triaged during scrum labels Jan 23, 2023
lab-at-nohl pushed a commit to lab-at-nohl/cockpit-389-ds-containerproxy that referenced this issue May 9, 2024
Descriptrion:

5607 - Ldap Editor failed to decode base64 values
5351 - CLI - Cockpit enable check for cockpit package was not portable
       (just removed this check)
5611 - Security page had a lot of issues when trying to change the Server
       Certificate.  Save didn't work, and "Security Enable" modal would
       crash

relates: 389ds/389-ds-base#5607
relates: 389ds/389-ds-base#5351
relates: 389ds/389-ds-base#5611

Reviewed by: spichugi(Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cockpit Cockpit UI Plugin
Projects
None yet
Development

No branches or pull requests

2 participants