Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"dsconf instance backend delete" is missing the non-interactive --do-it option #5425

Closed
minfrin opened this issue Aug 20, 2022 · 1 comment · Fixed by #5574
Closed

"dsconf instance backend delete" is missing the non-interactive --do-it option #5425

minfrin opened this issue Aug 20, 2022 · 1 comment · Fixed by #5574
Assignees
Labels
CLI CLI tools cockpit Cockpit UI Plugin
Milestone

Comments

@minfrin
Copy link
Contributor

minfrin commented Aug 20, 2022

Issue Description
The "dsconf instance backend delete" includes the interactive behaviour "Type 'Yes I am sure' to continue", but lacks the --do-it option used elsewhere in 389ds to allow non-interactive use.

Package Version and Platform:

  • Platform: RHEL9
  • Package and version: 389-ds-base-2.0.14-1.el9.x86_64
  • Browser: none

Steps to Reproduce
Steps to reproduce the behavior:

  1. Run "dsconf "ldapi://%2frun%2fslapd-${instance}.socket" backend delete "${bename}""
  2. See prompt "Type 'Yes I am sure' to continue:"

Expected results
The addition of --do-it causes success.

@minfrin minfrin added the needs triage The issue will be triaged during scrum label Aug 20, 2022
@mreynolds389
Copy link
Contributor

In main branch it works without any confirmation:

$ sudo dsconf slapd-localhost backend create --be-name markRoot --suffix o=mark --create-suffix
The database was sucessfully created

$ sudo dsconf slapd-localhost backend delete o=mark
The database, and any sub-suffixes, were sucessfully deleted

The 2.0 branch should behave the same way - I need to confirm that though...

On a side note I noticed we have a typo with "sucessfully" in the result messages:

lib389/cli_conf/backend.py: log.info("The database was sucessfully created")
lib389/cli_conf/backend.py: log.info("The database, and any sub-suffixes, were sucessfully deleted")

@mreynolds389 mreynolds389 self-assigned this Dec 16, 2022
@mreynolds389 mreynolds389 added cockpit Cockpit UI Plugin CLI CLI tools and removed needs triage The issue will be triaged during scrum labels Dec 16, 2022
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Dec 16, 2022
Description:  Add "--do-it" CLI argument when deleting a backend and its subsuffixes

fixes: 389ds#5425

Reviewed by: tbordaz & progier(Thanks!!)
@mreynolds389 mreynolds389 added this to the 2.x backlog milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI CLI tools cockpit Cockpit UI Plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants