Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode support #5581

Closed
vashirov opened this issue Dec 21, 2022 · 1 comment
Closed

Dark mode support #5581

vashirov opened this issue Dec 21, 2022 · 1 comment
Assignees
@mreynolds389
Labels
cockpit Cockpit UI Plugin needs triage The issue will be triaged during scrum

Comments

@vashirov
Copy link
Member

Issue Description
Cockpit supports dark mode since v269.
When enabled, our application has issues with the some of the components, see screenshots.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to Session (top right corner) and switch style to Dark, if not set automatically.

Expected results
Main banner and tree view for Server, Database, Replication, Monitoring tabs look consistent with the rest of the UI.

Screenshots
SCR-20221221-los-2
@vashirov vashirov added needs triage The issue will be triaged during scrum cockpit Cockpit UI Plugin labels Dec 21, 2022
@mreynolds389 mreynolds389 self-assigned this Jan 10, 2023
@mreynolds389 mreynolds389 mentioned this issue Jan 10, 2023
Merged
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 11, 2023
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
f833c9d 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: 389ds#5581

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2023
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
ea5daa5 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: #5581

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2023
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
cc63ca5 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: #5581

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2023
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
0403e95 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: #5581

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2023
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
73743dc 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: #5581

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2023
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
a606c91 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: #5581

Reviewed by: spichugi(Thanks!)
@mreynolds389
Copy link
Contributor

c81ee34..cc63ca5 389-ds-base-2.2 -> 389-ds-base-2.2
9398b86..0403e95 389-ds-base-2.1 -> 389-ds-base-2.1
ff6dbd9..73743dc 389-ds-base-2.0 -> 389-ds-base-2.0
74ebe98..a606c91 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

lab-at-nohl pushed a commit to lab-at-nohl/cockpit-389-ds-containerproxy that referenced this issue May 9, 2024
@mreynolds389
Issue 5581 - UI - Support cockpit dark theme
9359d90 
Description:  We were previously overriding the background color which caused
              issues with the dark theme.

              Also changed database tree to add  a "Create Suffix" Icon in the
              tree instead of the button below the tree

              Fixed browser crash in "edit entry" when changing read only
              variable

relates: 389ds/389-ds-base#5581

Reviewed by: spichugi(Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

Labels
cockpit Cockpit UI Plugin needs triage The issue will be triaged during scrum
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vashirov @mreynolds389