Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - fix tests #5588

Closed
mreynolds389 opened this issue Jan 5, 2023 · 4 comments
Closed

CI - fix tests #5588

mreynolds389 opened this issue Jan 5, 2023 · 4 comments
Assignees
@mreynolds389
Labels
needs triage The issue will be triaged during scrum
Milestone
2.2.0

Comments

@mreynolds389
Copy link
Contributor

Issue Description

Several ACL test are failing because the tests expect an INDEX exception, but now the server returns an empty list instead of the exception
@mreynolds389 mreynolds389 added the needs triage The issue will be triaged during scrum label Jan 5, 2023
@mreynolds389 mreynolds389 added this to the 2.2.0 milestone Jan 5, 2023
@mreynolds389 mreynolds389 self-assigned this Jan 5, 2023
@progier389
Copy link
Contributor

progier389 commented Jan 5, 2023 •
edited
Loading

Looking at test_deny_group_member_all_rights_to_group_members failure:

    user = UserAccount(conn, 'uid=test_user_1000,ou=ACLGroup,dc=example,dc=com')
    with pytest.raises(IndexError):
        user.get_attr_val_utf8('uid')

This seems a bit weird: according to RFC 4517, value with DirectoryString syntax should have at least 1 character, so the test seems OK. (uid should not be empty)
I think that we should double check if the server is really returning an attribute with an empty value (which would then be a server bug) or if it is a lib389 issue around UserAccount handling.

@mreynolds389 mreynolds389 changed the title CI - fix ACI tests CI - fix tests Jan 5, 2023
@mreynolds389
Copy link
Contributor Author

Looking at test_deny_group_member_all_rights_to_group_members failure:

    user = UserAccount(conn, 'uid=test_user_1000,ou=ACLGroup,dc=example,dc=com')
    with pytest.raises(IndexError):
        user.get_attr_val_utf8('uid')

This seems a bit weird: according to RFC 4517, value with DirectoryString syntax should have at least 1 character, so the test seems OK. (uid should not be empty) I think that we should double check if the server is really returning an attribute with an empty value (which would then be a server bug) or if it is a lib389 issue around UserAccount handling.

I think lib389 is just handling the error differently now. It's just testing if an aci is denying access to read "uid"

mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 5, 2023
@mreynolds389
Issue 5588 - Fix CI tests
224ee65 
Description:

Fix ACL tests that no longer return IndexError but instead return empty list
Fix db_home tests when in container and regular db dir is used instead
Fix repl monitor test where args_instance was not declared before treating it as dict

relates: 389ds#5588

Reviewed by: ?
@mreynolds389 mreynolds389 mentioned this issue Jan 5, 2023
Merged
mreynolds389 added a commit that referenced this issue Jan 5, 2023
@mreynolds389
Issue 5588 - Fix CI tests
2c28c89 
Description:

Fix ACL tests that no longer return IndexError but instead return empty list
Fix db_home tests when in container and regular db dir is used instead
Fix repl monitor test where args_instance was not declared before treating it as dict

relates: #5588

Reviewed by: ?
mreynolds389 added a commit that referenced this issue Jan 5, 2023
@mreynolds389
Issue 5588 - Fix CI tests
7baa5a1 
Description:

Fix ACL tests that no longer return IndexError but instead return empty list
Fix db_home tests when in container and regular db dir is used instead
Fix repl monitor test where args_instance was not declared before treating it as dict

relates: #5588

Reviewed by: ?
mreynolds389 added a commit that referenced this issue Jan 5, 2023
@mreynolds389
Issue 5588 - Fix CI tests
d8ddb4a 
Description:

Fix ACL tests that no longer return IndexError but instead return empty list
Fix db_home tests when in container and regular db dir is used instead
Fix repl monitor test where args_instance was not declared before treating it as dict

relates: #5588

Reviewed by: ?
@mreynolds389
Copy link
Contributor Author

51b0e50..7baa5a1 389-ds-base-2.2 -> 389-ds-base-2.2
17ac5d2..d8ddb4a 389-ds-base-2.1 -> 389-ds-base-2.1

@progier389 progier389 mentioned this issue Jan 6, 2023
Open
mreynolds389 added a commit that referenced this issue Jan 24, 2023
@mreynolds389
Issue 5588 - Fix CI tests
27df56c 
Description:

Fix ACL tests that no longer return IndexError but instead return empty list
Fix db_home tests when in container and regular db dir is used instead
Fix repl monitor test where args_instance was not declared before treating it as dict

relates: #5588

Reviewed by: ?
mreynolds389 added a commit that referenced this issue Jan 24, 2023
@mreynolds389
Issue 5588 - Fix CI tests
015c9ab 
Description:

Fix ACL tests that no longer return IndexError but instead return empty list
Fix db_home tests when in container and regular db dir is used instead
Fix repl monitor test where args_instance was not declared before treating it as dict

relates: #5588

Reviewed by: ?
@mreynolds389
Copy link
Contributor Author

2311160..27df56c 389-ds-base-2.0 -> 389-ds-base-2.0
5a5630d..015c9ab 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

@bsimonova bsimonova mentioned this issue Feb 7, 2023
Merged
bsimonova added a commit to bsimonova/389-ds-base that referenced this issue Feb 7, 2023
@bsimonova
Issue 5588 - CI - fix tests
d0a57bd 
Description:
Small fixes for 1.4.3 branch.
setup_ds_test had wrong brackets for parametrize and instead
of 'false' value, it was testing 'f', 'a' etc. values.
ssl_version_test - adjusting the ds version as TLS 1.0 and TLS 1.1
are on LEGACY policy on RHEL 8.8

Relates: 389ds#5588

Reviewed by: @aadhikar (Thanks!)
aadhikar pushed a commit that referenced this issue Feb 7, 2023
@bsimonova
Issue 5588 - CI - fix tests (#5633)
bb72096 
Description:
Small fixes for 1.4.3 branch.
setup_ds_test had wrong brackets for parametrize and instead
of 'false' value, it was testing 'f', 'a' etc. values.
ssl_version_test - adjusting the ds version as TLS 1.0 and TLS 1.1
are on LEGACY policy on RHEL 8.8

Relates: #5588

Reviewed by: @aadhikar (Thanks!)
@mreynolds389 mreynolds389 mentioned this issue Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

Labels
needs triage The issue will be triaged during scrum
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@mreynolds389 @progier389