Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cockpit 389ds plugin] Create a new custom Entry bug. #5602

Closed
cold01water opened this issue Jan 12, 2023 · 2 comments
Closed

[Cockpit 389ds plugin] Create a new custom Entry bug. #5602

cold01water opened this issue Jan 12, 2023 · 2 comments
Assignees
Labels
cockpit Cockpit UI Plugin
Milestone

Comments

@cold01water
Copy link

Issue Description
An error occurs when selecting an object class in "Create a new custom Entry" from the LDAP browser.

Package Version and Platform:

  • Platform: Almalinux9
  • Package and version: github master branch (2023/1/12)
  • Browser: Edge

Steps to Reproduce
the above

Expected results
You should be able to select object classes and add entries.

Additional context

The problem is that the following code is trying to assign to a "const" variable.
If you change it to "let", it will work fine.

  • 389-ds-base/src/cockpit/389-console/src/lib/ldap_editor/wizards/operations/addLdapEntry.jsx
444             for (const attr of required) {
445                 attr = attr.trim().toLowerCase();

(snip)

496             for (const attr of optional) {
497                 attr = attr.trim();
@cold01water cold01water added the needs triage The issue will be triaged during scrum label Jan 12, 2023
@mreynolds389
Copy link
Contributor

Yes we found a similar bug recently with editLdapEntry. This code used to work (incorrectly) but now browsers have apparently gotten stricter and are now exposing these bugs. We'll get this fixed asap.

@mreynolds389 mreynolds389 self-assigned this Jan 12, 2023
@mreynolds389 mreynolds389 added cockpit Cockpit UI Plugin and removed needs triage The issue will be triaged during scrum labels Jan 12, 2023
@mreynolds389 mreynolds389 added this to the 1.4.3 milestone Jan 12, 2023
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 12, 2023
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: 389ds#5602

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 12, 2023
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: #5602

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 12, 2023
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: #5602

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 12, 2023
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: #5602

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 12, 2023
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: #5602

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 12, 2023
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: #5602

Reviewed by: spichugi(Thanks!)
@mreynolds389
Copy link
Contributor

cc63ca5..fee16db 389-ds-base-2.2 -> 389-ds-base-2.2
0403e95..22de3d7 389-ds-base-2.1 -> 389-ds-base-2.1
73743dc..7c8d2e5 389-ds-base-2.0 -> 389-ds-base-2.0
a606c91..c0bb1a7 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

All fixed now...

lab-at-nohl pushed a commit to lab-at-nohl/cockpit-389-ds-containerproxy that referenced this issue May 9, 2024
Description:  Existing code that used to work (incorrectly) is now causing issues.
              Need to use "let" instead of "const".

relates: 389ds/389-ds-base#5602

Reviewed by: spichugi(Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cockpit Cockpit UI Plugin
Projects
None yet
Development

No branches or pull requests

2 participants