Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizing Cockpit's 389ds Plugin using CockpitPoPlugin #5732

Open
designet-inc-oss opened this issue Apr 18, 2023 · 3 comments
Open

Localizing Cockpit's 389ds Plugin using CockpitPoPlugin #5732

designet-inc-oss opened this issue Apr 18, 2023 · 3 comments
Labels
needs triage The issue will be triaged during scrum

Comments

@designet-inc-oss
Copy link
Contributor

Hello,

We are interested in contributing to the localization of cockpit's 389ds plugin and would like to discuss our proposed approach for making modifications.

Previously, cockpit was built using webpack. However, the latest version now uses esbuild. The issue we face is that the 389ds plugin for cockpit is built using webpack, which means that the transpilation process cannot be easily ported over.

To enable localization of 389ds, we propose bringing the CockpitPoPlugin from the old cockpit's pkg/lib/cockpit-po-plugin.js and calling it in webpack.config.js, so that 389ds can handle language files (po files) as well. We would like to contribute to the project once the localization is done.

What do you think about this proposed solution? Please let us know if you have any better suggestions.

@designet-inc-oss designet-inc-oss added the needs triage The issue will be triaged during scrum label Apr 18, 2023
@mreynolds389
Copy link
Contributor

This would be a very welcomed contribution! It's an area we know we needed to work on, but simply have not had the time to work on.

@designet-inc-oss
Copy link
Contributor Author

Thank you for your response.
Alright, I'll start working on localization right away!

By the way, we plan to create Japanese as the first language for localization.
I'll send a pull request once it's completed, so please look forward to it.

droideck pushed a commit that referenced this issue Sep 21, 2023
…5764)

Description: To enable localization for 389ds, we obtained CockpitPoPlugin from pkg/lib/cockpit-po-plugin.js in the old Cockpit, called it in webpack.config.js, and modified the files so that 389ds can handle language files (po files).

Relates: #5732

Author: designet-inc-oss

Reviewed by: @mreynolds389, @vashirov, @droideck (Thanks!)
droideck pushed a commit that referenced this issue Sep 21, 2023
…5764)

Description: To enable localization for 389ds, we obtained CockpitPoPlugin from
pkg/lib/cockpit-po-plugin.js in the old Cockpit, called it in webpack.config.js,
and modified the files so that 389ds can handle language files (po files).

Relates: #5732

Author: designet-inc-oss

Reviewed by: @mreynolds389, @vashirov, @droideck (Thanks!)
@droideck
Copy link
Member

8b4b830..5308908 389-ds-base-2.3 -> 389-ds-base-2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage The issue will be triaged during scrum
Projects
None yet
Development

No branches or pull requests

3 participants